Skip to content

[AMDGPU][gfx1250] Check for GloballyAddressableScratch in mayAccessScratchThroughFlat #160669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −2
Closed

[AMDGPU][gfx1250] Check for GloballyAddressableScratch in mayAccessScratchThroughFlat #160669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4319,8 +4319,10 @@ bool SIInstrInfo::mayAccessScratchThroughFlat(const MachineInstr &MI) const {
if (!isFLAT(MI) || isFLATGlobal(MI))
return false;

// If scratch is not initialized, we can never access it.
if (MI.getMF()->getFunction().hasFnAttribute("amdgpu-no-flat-scratch-init"))
// If scratch is not initialized, we can never access it unless the target has
// the ability to access scratch outside its own thread.
if (!ST.hasGloballyAddressableScratch() &&
MI.getMF()->getFunction().hasFnAttribute("amdgpu-no-flat-scratch-init"))
return false;

// SCRATCH instructions always access scratch.
Expand Down
Loading