[llvm] Use the VFS to get the real path in FileCollector

[jansvoboda11]

This PR starts using the correct VFS for getting file's real path in FileCollector instead of using the real FS directly. This matches compiler's behavior for other input files.

[llvmbot]

@llvm/pr-subscribers-llvm-support

Author: Jan Svoboda (jansvoboda11)

Changes

This PR starts using the correct VFS for getting file's real path in FileCollector instead of using the real FS directly. This matches compiler's behavior for other input files.

---

Full diff: https://github.com/llvm/llvm-project/pull/160943.diff

1 Files Affected:

• (modified) llvm/lib/Support/FileCollector.cpp (+2-3)

diff --git a/llvm/lib/Support/FileCollector.cpp b/llvm/lib/Support/FileCollector.cpp
index 5dc224a6d427b..1e5de2c49a2b3 100644
--- a/llvm/lib/Support/FileCollector.cpp
+++ b/llvm/lib/Support/FileCollector.cpp
@@ -68,9 +68,8 @@ void FileCollector::PathCanonicalizer::updateWithRealPath(
   SmallString<256> RealPath;
   auto DirWithSymlink = CachedDirs.find(Directory);
   if (DirWithSymlink == CachedDirs.end()) {
-    // FIXME: Should this be a call to FileSystem::getRealpath(), in some
-    // cases? What if there is nothing on disk?
-    if (sys::fs::real_path(Directory, RealPath))
+    // FIXME: What if there is nothing on disk?
+    if (VFS->getRealPath(Directory, RealPath))
       return;
     CachedDirs[Directory] = std::string(RealPath);
   } else {

[cachemeifyoucan]

LGTM. Seems like a simple improvement.