Skip to content

[BOLT] Exit early when prepareToParse fails on buildid #161151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Draft

[BOLT] Exit early when prepareToParse fails on buildid #161151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfd0874
[BOLT] Exit early when prepareToParse fails on buildid
paschalis-mpeis Sep 29, 2025
066ebee
Avoid prepareToParse crash
paschalis-mpeis Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion bolt/lib/Profile/DataAggregator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,18 @@ int DataAggregator::prepareToParse(StringRef Name, PerfProcessInfo &Process,
if (PI.ReturnCode != 0) {
ErrorOr<std::unique_ptr<MemoryBuffer>> ErrorMB =
MemoryBuffer::getFileOrSTDIN(Process.StderrPath.data());
StringRef ErrBuf = (*ErrorMB)->getBuffer();
std::string ErrMsg;
StringRef ErrBuf;
if (std::error_code EC = ErrorMB.getError()) {
ErrMsg = "PERF2BOLT: cannot open ";
ErrMsg += Process.StderrPath.data();
ErrMsg += ": ";
ErrMsg += EC.message();
ErrMsg += '\n';
ErrBuf = ErrMsg;
} else {
ErrBuf = (*ErrorMB)->getBuffer();
}

deleteTempFiles();
Callback(PI.ReturnCode, ErrBuf);
Expand Down
Loading