Skip to content

fix template compilation issue in flang-rt, fix issue #160534 #161250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

fix template compilation issue in flang-rt, fix issue #160534 #161250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f70914a
fix template compilation issue in flang-rt, fix issue #160534
Nir-Cohen-2003 Sep 29, 2025
8f60ffd
fix memset to use freestanding tool instead of stdlib
Nir-Cohen-2003 Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flang-rt/lib/runtime/matmul-transpose.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,8 @@ struct MatmulTransposeHelper {
RUNTIME_CHECK(terminator, xCatKind.has_value() && yCatKind.has_value());
RUNTIME_CHECK(terminator, xCatKind->first == XCAT);
RUNTIME_CHECK(terminator, yCatKind->first == YCAT);
if constexpr (constexpr ResultTy resultType{
GetResultType(XCAT, XKIND, YCAT, YKIND)}) {
constexpr ResultTy resultType{GetResultType(XCAT, XKIND, YCAT, YKIND)};
if constexpr (resultType) {
Comment on lines +343 to +344
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be ok to change.

return DoMatmulTranspose<IS_ALLOCATING, resultType->first,
resultType->second, CppTypeFor<XCAT, XKIND>, CppTypeFor<YCAT, YKIND>>(
result, x, y, terminator);
Expand Down
4 changes: 2 additions & 2 deletions flang-rt/lib/runtime/matmul.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,8 @@ struct MatmulHelper {
xCatKind->first == TypeCategory::Unsigned) &&
(yCatKind->first == TypeCategory::Integer ||
yCatKind->first == TypeCategory::Unsigned))));
if constexpr (constexpr ResultTy resultType{
GetResultType(XCAT, XKIND, YCAT, YKIND)}) {
constexpr ResultTy resultType{GetResultType(XCAT, XKIND, YCAT, YKIND)};
if constexpr (resultType) {
return DoMatmul<IS_ALLOCATING, resultType->first, resultType->second,
CppTypeFor<XCAT, XKIND>, CppTypeFor<YCAT, YKIND>>(
result, x, y, terminator);
Expand Down