Skip to content

[sanitizers][Darwin][NFC] Insert missing void* casts for printf %p #161282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

[sanitizers][Darwin][NFC] Insert missing void* casts for printf %p #161282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,8 +1147,8 @@ static void PrintVmmap() {
lastsz += vmsize;
} else {
if (lastsz)
Printf("|| `[%p, %p]` || size=0x%016" PRIx64 " ||\n", last,
last + lastsz, lastsz);
Printf("|| `[%p, %p]` || size=0x%016" PRIx64 " ||\n", (void*)last,
(void*)(last + lastsz), lastsz);

last = address;
lastsz = vmsize;
Expand All @@ -1158,8 +1158,8 @@ static void PrintVmmap() {
// We've reached the end of the memory map. Print the last remaining
// region, if there is one.
if (lastsz)
Printf("|| `[%p, %p]` || size=0x%016" PRIx64 " ||\n", last,
last + lastsz, lastsz);
Printf("|| `[%p, %p]` || size=0x%016" PRIx64 " ||\n", (void*)last,
(void*)(last + lastsz), lastsz);

break;
}
Expand All @@ -1170,7 +1170,7 @@ static void ReportShadowAllocFail(uptr shadow_size_bytes, uptr alignment) {
Report(
"FATAL: Failed to allocate shadow memory. Tried to allocate %p bytes "
"(alignment=%p).\n",
shadow_size_bytes, alignment);
(void*)shadow_size_bytes, (void*)alignment);
PrintVmmap();
}

Expand Down
2 changes: 1 addition & 1 deletion compiler-rt/lib/tsan/rtl/tsan_platform_mac.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ void InitializePlatformEarly() {
Report(
"ThreadSanitizer: Unsupported virtual memory layout: Address %p is "
"already mapped.\n",
HiAppMemEnd() - 1);
(void*)(HiAppMemEnd() - 1));
Die();
}
#endif
Expand Down