Skip to content

Conversation

cofibrant
Copy link
Contributor

@cofibrant cofibrant commented Oct 3, 2025

This patch improves CMake configuration time for Darwin builds by removing the need to search for sysroots for disabled targets. In particular, when the disabled targets are not installed, this search takes a while to fail.

CC @fhahn @citymarina

Copy link

github-actions bot commented Oct 3, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@cofibrant cofibrant force-pushed the cofibrant/compiler-rt-darwin-sysroot-search branch from 3b9eb58 to f401a66 Compare October 6, 2025 16:55
@citymarina
Copy link
Contributor

Thanks for doing this. This LGTM but I'd prefer that some other reviewers have a look too.

@cofibrant
Copy link
Contributor Author

Ping

@cofibrant cofibrant force-pushed the cofibrant/compiler-rt-darwin-sysroot-search branch from f401a66 to 4d465b3 Compare October 21, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants