[cmake] disable CMP0179 for gnu-ld #161951
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For symbol not referenced when resolving an archive file, it fails in here. The gnu-ld will optimize so that an object file in the archive does not have any referenced symbol won't be loaded. The archive_symbol_lookup lookups the internal hash table (not gnu.hashtable) section to see if a symbol has appeared before. Therefore, if libLLVMTableGen is not put before libLLVMSupport, it fails to be found in the hash table. |
aokblast
changed the title
The gnu-ld resolves archive files (static library) in order. Therefore, we should disable CMP0179 so that CMake will generate the correct order.
aokblast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gnu-ld resolves archive files (static library in CMake) in order.
Therefore, we should disable CMP0179 so that CMake will generate the
correct order.