Skip to content

Conversation

smallzhong
Copy link
Contributor

Corrected the string from 'expect' to 'except' for the STYP_EXCEPT section in XCOFFObjectFile.cpp.

Corrected the string from 'expect' to 'except' for the STYP_EXCEPT section in XCOFFObjectFile.cpp.
Copy link

github-actions bot commented Oct 4, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Oct 4, 2025

@llvm/pr-subscribers-llvm-binary-utilities

Author: 小钟 (smallzhong)

Changes

Corrected the string from 'expect' to 'except' for the STYP_EXCEPT section in XCOFFObjectFile.cpp.


Full diff: https://github.com/llvm/llvm-project/pull/161959.diff

1 Files Affected:

  • (modified) llvm/lib/Object/XCOFFObjectFile.cpp (+1-1)
diff --git a/llvm/lib/Object/XCOFFObjectFile.cpp b/llvm/lib/Object/XCOFFObjectFile.cpp
index c5a2ec219e91c..68809627b56c9 100644
--- a/llvm/lib/Object/XCOFFObjectFile.cpp
+++ b/llvm/lib/Object/XCOFFObjectFile.cpp
@@ -473,7 +473,7 @@ Expected<uintptr_t> XCOFFObjectFile::getSectionFileOffsetToRawData(
       ECASE(STYP_TEXT, "text");
       ECASE(STYP_DATA, "data");
       ECASE(STYP_BSS, "bss");
-      ECASE(STYP_EXCEPT, "expect");
+      ECASE(STYP_EXCEPT, "except");
       ECASE(STYP_INFO, "info");
       ECASE(STYP_TDATA, "tdata");
       ECASE(STYP_TBSS, "tbss");

Copy link
Collaborator

@jh7370 jh7370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable to me, but I'd like an XCOFF maintainer to sign off, so I've added a few who I know work in the area, as reviewers.

@jh7370
Copy link
Collaborator

jh7370 commented Oct 6, 2025

Oh, you need to mark your email address as not private in GitHub for this to be merged. Please see https://llvm.org/docs/DeveloperPolicy.html#email-addresses.

@smallzhong
Copy link
Contributor Author

Oh, you need to mark your email address as not private in GitHub for this to be merged. Please see https://llvm.org/docs/DeveloperPolicy.html#email-addresses.

Thanks for the reminder! I’ve disabled the “Keep my email addresses private” option in my GitHub settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants