[X86][GlobalIsel] Support G_IS_FPCLASS #162232
Merged
+360
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current generic lowering differs from SDAG in two ways.
|
Missing Optimization issue #162248 |
e-kud
reviewed
Oct 8, 2025
Comment on lines
6
to
7
| ; RUN: llc < %s -mtriple=i686-linux -global-isel -global-isel-abort=1 | FileCheck %s -check-prefixes=X86,X86-GISEL | ||
| ; RUN: llc < %s -mtriple=x86_64-linux -global-isel -global-isel-abort=1 | FileCheck %s -check-prefixes=X64,X64-GISEL |
There was a problem hiding this comment.
Maybe drop X86 and X64 from GlobalISel? Or introduce a common prefix for SDAG and FASTISEL. FASTISEL duplicates SDAG significantly.
There was a problem hiding this comment.
Removing X86 check label from globalisel run is conflict, X64 removal helps to reduce lines by ~70 lines.
Common prefix for DAG and FASTISEL was not much useful, reported message of unused prefix at bottom.
Change updated here.
arsenm
approved these changes
Oct 10, 2025
|
If no objections, can we merge? |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/187/builds/12521 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/17095 Here is the relevant piece of the build log for the reference |
|
@mahesh-attarde please can you investigate the EXPENSIVE_CHECKS build failures? |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/13164 Here is the relevant piece of the build log for the reference |
I am working on it. |
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
Some of dependency opcodes for G_IS_FPCLASS are now supported. This patch adds lowering for G_IS_FPCLASS. Test is updated for GISEL Run separately [Test PR] llvm#160741.
Failure reported here is related to G_CONSTANT i8 0. GIR. GISEL LOG DAG LOG I tried few approaches to deal with same, those ended up with regressions on DAG. I this takes up more time, I will submit disabling for i686 RUN and continue fixing it. |
Basically the problem is that for this code SDAG can use |
|
Regrettably, I think its time to revert this and get EXPENSIVE_CHECKS green again. |
RKSimon
added a commit
that referenced
this pull request
Oct 16, 2025
Reverts #162232 due to failures on EXPENSIVE_CHECKS enabled targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of dependency opcodes for G_IS_FPCLASS are now supported. This patch adds lowering for G_IS_FPCLASS.
Test is updated for GISEL Run separately Test PR.