Fix spelling of 'auxiliary' in XCOFF and related docs #162870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects multiple instances of the misspelling 'auxilliary' to 'auxiliary' in comments and documentation across XCOFF-related source files, headers, and tests.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
lldb
backend:PowerPC
llvm:mc
|
@llvm/pr-subscribers-backend-powerpc @llvm/pr-subscribers-lldb Author: 小钟 (smallzhong) ChangesCorrects multiple instances of the misspelling 'auxilliary' to 'auxiliary' in comments and documentation across XCOFF-related source files, headers, and tests. Full diff: https://github.com/llvm/llvm-project/pull/162870.diff 6 Files Affected:
diff --git a/lldb/include/lldb/Symbol/SymbolFile.h b/lldb/include/lldb/Symbol/SymbolFile.h
index 3b4d7bc01d132..50036c2ea049b 100644
--- a/lldb/include/lldb/Symbol/SymbolFile.h
+++ b/lldb/include/lldb/Symbol/SymbolFile.h
@@ -174,9 +174,9 @@ class SymbolFile : public PluginInterface {
/// object files.
///
/// \param comp_unit
- /// When this SymbolFile consists of multiple auxilliary
+ /// When this SymbolFile consists of multiple auxiliary
/// SymbolFiles, for example, a Darwin debug map that references
- /// multiple .o files, comp_unit helps choose the auxilliary
+ /// multiple .o files, comp_unit helps choose the auxiliary
/// file. In most other cases comp_unit's symbol file is
/// identical with *this.
///
diff --git a/llvm/include/llvm/IR/MDBuilder.h b/llvm/include/llvm/IR/MDBuilder.h
index df1c66cf24fcb..62184be96739b 100644
--- a/llvm/include/llvm/IR/MDBuilder.h
+++ b/llvm/include/llvm/IR/MDBuilder.h
@@ -143,7 +143,7 @@ class MDBuilder {
// PC sections metadata.
//===------------------------------------------------------------------===//
- /// A pair of PC section name with auxilliary constant data.
+ /// A pair of PC section name with auxiliary constant data.
using PCSection = std::pair<StringRef, SmallVector<Constant *>>;
/// Return metadata for PC sections.
diff --git a/llvm/lib/MC/XCOFFObjectWriter.cpp b/llvm/lib/MC/XCOFFObjectWriter.cpp
index fce6b2ac5cf8d..ad99f566655e4 100644
--- a/llvm/lib/MC/XCOFFObjectWriter.cpp
+++ b/llvm/lib/MC/XCOFFObjectWriter.cpp
@@ -946,15 +946,15 @@ void XCOFFWriter::writeSymbolEntryForCsectMemberLabel(
(is64Bit() && ExceptionSection.isDebugEnabled) ? 3 : 2);
if (is64Bit() && ExceptionSection.isDebugEnabled) {
// On 64 bit with debugging enabled, we have a csect, exception, and
- // function auxilliary entries, so we must increment symbol index by 4.
+ // function auxiliary entries, so we must increment symbol index by 4.
writeSymbolAuxExceptionEntry(
ExceptionSection.FileOffsetToData +
getExceptionOffset(Entry->second.FunctionSymbol),
Entry->second.FunctionSize,
SymbolIndexMap[Entry->second.FunctionSymbol] + 4);
}
- // For exception section entries, csect and function auxilliary entries
- // must exist. On 64-bit there is also an exception auxilliary entry.
+ // For exception section entries, csect and function auxiliary entries
+ // must exist. On 64-bit there is also an exception auxiliary entry.
writeSymbolAuxFunctionEntry(
ExceptionSection.FileOffsetToData +
getExceptionOffset(Entry->second.FunctionSymbol),
@@ -1015,7 +1015,7 @@ void XCOFFWriter::writeSymbolAuxFunctionEntry(uint32_t EntryOffset,
void XCOFFWriter::writeSymbolAuxExceptionEntry(uint64_t EntryOffset,
uint32_t FunctionSize,
uint32_t EndIndex) {
- assert(is64Bit() && "Exception auxilliary entries are 64-bit only.");
+ assert(is64Bit() && "Exception auxiliary entries are 64-bit only.");
W.write<uint64_t>(EntryOffset);
W.write<uint32_t>(FunctionSize);
W.write<uint32_t>(EndIndex);
@@ -1348,7 +1348,7 @@ void XCOFFWriter::addExceptionEntry(const MCSymbol *Symbol,
unsigned ReasonCode, unsigned FunctionSize,
bool hasDebug) {
// If a module had debug info, debugging is enabled and XCOFF emits the
- // exception auxilliary entry.
+ // exception auxiliary entry.
if (hasDebug)
ExceptionSection.isDebugEnabled = true;
auto Entry = ExceptionSection.ExceptionTable.find(Symbol->getName());
@@ -1474,8 +1474,8 @@ void XCOFFWriter::assignAddressesAndIndices(MCAssembler &Asm) {
SymbolIndexMap[Sym.MCSym] = Sym.SymbolTableIndex;
// 1 main and 1 auxiliary symbol table entry for each contained
// symbol. For symbols with exception section entries, a function
- // auxilliary entry is needed, and on 64-bit XCOFF with debugging
- // enabled, an additional exception auxilliary entry is needed.
+ // auxiliary entry is needed, and on 64-bit XCOFF with debugging
+ // enabled, an additional exception auxiliary entry is needed.
SymbolTableIndex += 2;
if (hasExceptionSection() && hasExceptEntry) {
if (is64Bit() && ExceptionSection.isDebugEnabled)
diff --git a/llvm/lib/Object/XCOFFObjectFile.cpp b/llvm/lib/Object/XCOFFObjectFile.cpp
index c5a2ec219e91c..c26fe2c914850 100644
--- a/llvm/lib/Object/XCOFFObjectFile.cpp
+++ b/llvm/lib/Object/XCOFFObjectFile.cpp
@@ -1331,7 +1331,7 @@ Expected<XCOFFCsectAuxRef> XCOFFSymbolRef::getXCOFFCsectAuxRef() const {
}
if (!getObject()->is64Bit()) {
- // In XCOFF32, the csect auxilliary entry is always the last auxiliary
+ // In XCOFF32, the csect auxiliary entry is always the last auxiliary
// entry for the symbol.
uintptr_t AuxAddr = XCOFFObjectFile::getAdvancedSymbolEntryAddress(
getEntryAddress(), NumberOfAuxEntries);
diff --git a/llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section-debug.ll b/llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section-debug.ll
index 7b66148044ddc..fca066f94e4e7 100644
--- a/llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section-debug.ll
+++ b/llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section-debug.ll
@@ -1,12 +1,12 @@
; This file contains exception section testing for when debug information is present.
-; The 32-bit test should not print exception auxilliary entries because they are a 64-bit only feature.
-; Exception auxilliary entries are present in the 64-bit tests because 64-bit && debug enabled are the requirements.
+; The 32-bit test should not print exception auxiliary entries because they are a 64-bit only feature.
+; Exception auxiliary entries are present in the 64-bit tests because 64-bit && debug enabled are the requirements.
; RUN: llc -mtriple=powerpc-ibm-aix-xcoff -mcpu=ppc -filetype=obj -o %t_32.o < %s
; RUN: llvm-readobj --syms %t_32.o | FileCheck %s --check-prefix=SYMS32
; RUN: llc -mtriple=powerpc64-unknown-aix -mcpu=ppc -filetype=obj -o %t_32.o < %s
; RUN: llvm-readobj --syms %t_32.o | FileCheck %s --check-prefix=SYMS64
-; If any debug information is included in a module and is XCOFF64, exception auxilliary entries are emitted
+; If any debug information is included in a module and is XCOFF64, exception auxiliary entries are emitted
!llvm.module.flags = !{!0, !1}
!llvm.dbg.cu = !{!2}
diff --git a/llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section.ll b/llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section.ll
index fbcb62a49f972..8b9850ffddee2 100644
--- a/llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section.ll
+++ b/llvm/test/CodeGen/PowerPC/aix-xcoff-exception-section.ll
@@ -1,4 +1,4 @@
-; Testing 32-bit and 64-bit exception section entries, no exception auxilliary
+; Testing 32-bit and 64-bit exception section entries, no exception auxiliary
; entries should be produced as no debug information is specified.
; RUN: llc -mtriple=powerpc-ibm-aix-xcoff -mcpu=ppc -filetype=obj -o %t_32.o < %s
; RUN: llvm-readobj --exception-section %t_32.o | FileCheck %s --check-prefix=EXCEPT
|
|
I forgot to sign the commit. I will close this PR and submit a new one. |
Commit signing isn't a thing that's required by LLVM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects multiple instances of the misspelling 'auxilliary' to 'auxiliary' in comments and documentation across XCOFF-related source files, headers, and tests.