-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[libclang/python] Add isFunctionInlined support #162882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TApplencourt
wants to merge
9
commits into
llvm:main
Choose a base branch
from
TApplencourt:cindex_inline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−0
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
674bdfb
Add isFunctionInlined support in Python Binding
TApplencourt 91b9d79
Merge branch 'main' into cindex_inline
TApplencourt 7a69e7d
Add isFunctionInlined support in Python Binding
TApplencourt 9efe91b
Use bool implace of c_int
TApplencourt 8c14af8
Docstrings should end with a period
TApplencourt 6edd33c
add ReleaseNotes
TApplencourt 484b385
Add test for is_function_inlined
TApplencourt a5d081c
Remove assert
TApplencourt 0d1268c
Add more tests
TApplencourt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -615,6 +615,7 @@ Sanitizers | |||||
|
|
||||||
| Python Binding Changes | ||||||
| ---------------------- | ||||||
| - Exposed ``clang_Cursor_is_function_inlined``. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| - Exposed ``clang_getCursorLanguage`` via ``Cursor.language``. | ||||||
| - Add all missing ``CursorKind``s, ``TypeKind``s and | ||||||
| ``ExceptionSpecificationKind``s from ``Index.h`` | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answering the question from the PR description,
c_uintreflects C function signature. I took a look at ctypes implementation, but I'm still not sure howboolis handled. If it's https://github.com/python/cpython/blob/b3a38438d83245e52dff80f348c7fde539333cea/Modules/_ctypes/cfield.c#L713, then I'm not particularly happy aboutunsignedread as widerlong long.