Skip to content

[AMDGPU] Remove NoInfsFPMath uses #163028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
+5 −8
Merged

[AMDGPU] Remove NoInfsFPMath uses #163028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2833,8 +2833,8 @@ SDValue AMDGPUTargetLowering::LowerFLOGCommon(SDValue Op,
R = getMad(DAG, DL, VT, YH, CH, Mad1);
}

const bool IsFiniteOnly = (Flags.hasNoNaNs() || Options.NoNaNsFPMath) &&
(Flags.hasNoInfs() || Options.NoInfsFPMath);
const bool IsFiniteOnly =
(Flags.hasNoNaNs() || Options.NoNaNsFPMath) && Flags.hasNoInfs();

// TODO: Check if known finite from source value.
if (!IsFiniteOnly) {
Expand Down Expand Up @@ -3161,9 +3161,8 @@ SDValue AMDGPUTargetLowering::lowerFEXP(SDValue Op, SelectionDAG &DAG) const {
DAG.getSetCC(SL, SetCCVT, X, UnderflowCheckConst, ISD::SETOLT);

R = DAG.getNode(ISD::SELECT, SL, VT, Underflow, Zero, R);
const auto &Options = getTargetMachine().Options;

if (!Flags.hasNoInfs() && !Options.NoInfsFPMath) {
if (!Flags.hasNoInfs()) {
SDValue OverflowCheckConst =
DAG.getConstantFP(IsExp10 ? 0x1.344136p+5f : 0x1.62e430p+6f, SL, VT);
SDValue Overflow =
Expand Down
6 changes: 2 additions & 4 deletions llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3575,7 +3575,7 @@ bool AMDGPULegalizerInfo::legalizeFlogCommon(MachineInstr &MI,

const bool IsFiniteOnly =
(MI.getFlag(MachineInstr::FmNoNans) || TM.Options.NoNaNsFPMath) &&
(MI.getFlag(MachineInstr::FmNoInfs) || TM.Options.NoInfsFPMath);
MI.getFlag(MachineInstr::FmNoInfs);

if (!IsFiniteOnly) {
// Expand isfinite(x) => fabs(x) < inf
Expand Down Expand Up @@ -3864,9 +3864,7 @@ bool AMDGPULegalizerInfo::legalizeFExp(MachineInstr &MI,

R = B.buildSelect(Ty, Underflow, Zero, R);

const auto &Options = MF.getTarget().Options;

if (!(Flags & MachineInstr::FmNoInfs) && !Options.NoInfsFPMath) {
if (!(Flags & MachineInstr::FmNoInfs)) {
auto OverflowCheckConst =
B.buildFConstant(Ty, IsExp10 ? 0x1.344136p+5f : 0x1.62e430p+6f);

Expand Down