[clang-format] Fix an assertion failure on comment-only config files

[owenca]

No description provided.

[llvmbot]

@llvm/pr-subscribers-clang-format

Author: owenca (owenca)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/163111.diff

2 Files Affected:

• (modified) clang/lib/Format/Format.cpp (+2-1)
• (modified) clang/unittests/Format/ConfigParseTest.cpp (+7)

diff --git a/clang/lib/Format/Format.cpp b/clang/lib/Format/Format.cpp
index 686e54128d372..093e88ffcc85d 100644
--- a/clang/lib/Format/Format.cpp
+++ b/clang/lib/Format/Format.cpp
@@ -2184,8 +2184,9 @@ std::error_code parseConfiguration(llvm::MemoryBufferRef Config,
   Input >> Styles;
   if (Input.error())
     return Input.error();
+  if (Styles.empty())
+    return make_error_code(ParseError::Success);
 
-  assert(!Styles.empty());
   const auto StyleCount = Styles.size();
 
   // Start from the second style as (only) the first one may be the default.
diff --git a/clang/unittests/Format/ConfigParseTest.cpp b/clang/unittests/Format/ConfigParseTest.cpp
index 6111e86ff7076..52f02c3ba8686 100644
--- a/clang/unittests/Format/ConfigParseTest.cpp
+++ b/clang/unittests/Format/ConfigParseTest.cpp
@@ -1264,6 +1264,13 @@ TEST(ConfigParseTest, ParsesConfigurationWithLanguages) {
               IndentWidth, 56u);
 }
 
+TEST(ConfigParseTest, AllowCommentOnlyConfigFile) {
+  FormatStyle Style = {};
+  Style.Language = FormatStyle::LK_Cpp;
+  EXPECT_EQ(parseConfiguration("#Language: C", &Style), ParseError::Success);
+  EXPECT_EQ(Style.Language, FormatStyle::LK_Cpp);
+}
+
 TEST(ConfigParseTest, AllowCppForC) {
   FormatStyle Style = {};
   Style.Language = FormatStyle::LK_C;

[owenca]

/cherry-pick 059f2df

[llvmbot]

Failed to cherry-pick: 059f2df

https://github.com/llvm/llvm-project/actions/runs/18582710285

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

[owenca]

/cherry-pick d7921de 059f2df

[llvmbot]

/pull-request #163919