Skip to content

Conversation

philnik777
Copy link
Contributor

@philnik777 philnik777 commented Oct 14, 2025

__alignas_is_defined and __alignof_is_defined are a C++11 feature which we only recently added. I don't think it will break anybody if we don't provide these macros in C++03, so this simply disable the test instead.

@philnik777 philnik777 requested a review from a team as a code owner October 14, 2025 10:15
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 14, 2025

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

__alignas_is_defined and __alignof_is_defined are a C++11 feature which we only recently added. I don't think it will break anybody if we don't provide these macros in C++03, so this simply disables the test instead.


Full diff: https://github.com/llvm/llvm-project/pull/163357.diff

1 Files Affected:

  • (modified) libcxx/test/std/language.support/support.runtime/cstdalign.compile.pass.cpp (+1-1)
diff --git a/libcxx/test/std/language.support/support.runtime/cstdalign.compile.pass.cpp b/libcxx/test/std/language.support/support.runtime/cstdalign.compile.pass.cpp
index 69296dfa50121..d289ef63dfec1 100644
--- a/libcxx/test/std/language.support/support.runtime/cstdalign.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.runtime/cstdalign.compile.pass.cpp
@@ -10,7 +10,7 @@
 
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
-// XFAIL: FROZEN-CXX03-HEADERS-FIXME
+// UNSUPPORTED: c++03
 
 #include <cstdalign>
 

@philnik777 philnik777 merged commit bef39e6 into llvm:main Oct 16, 2025
80 checks passed
@philnik777 philnik777 deleted the cxx03_disable_cstdalign_test branch October 16, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants