Skip to content

[asan] Make GetFakeStackFast()/GetFakeStackFastAlways() lazily init fake_stack_tls #163481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 16, 2025
Merged

[asan] Make GetFakeStackFast()/GetFakeStackFastAlways() lazily init fake_stack_tls #163481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a303bd7
[𝘀𝗽𝗿] initial version
vitalybuka Oct 15, 2025
c5887f3
hide GetTLSFakeStack
vitalybuka Oct 15, 2025
8a0fb91
hide GetTLSFakeStack
vitalybuka Oct 15, 2025
4c09d65
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Oct 16, 2025
e81b7e9
rebase
vitalybuka Oct 16, 2025
8f6aae9
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Oct 16, 2025
c4a2d70
rebase
vitalybuka Oct 16, 2025
1b13429
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Oct 16, 2025
a755001
rebase
vitalybuka Oct 16, 2025
3616991
rebase
vitalybuka Oct 16, 2025
17fbe43
rebase
vitalybuka Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions compiler-rt/lib/asan/asan_fake_stack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,17 +231,25 @@ static FakeStack* GetFakeStack() {
}

static FakeStack* GetFakeStackFast() {
if (FakeStack* fs = GetTLSFakeStack())
FakeStack* fs = GetTLSFakeStack();
if (LIKELY(fs))
return fs;
if (!__asan_option_detect_stack_use_after_return)
return nullptr;
return GetFakeStack();
fs = GetFakeStack();
if (LIKELY(fs))
SetTLSFakeStack(fs);
return fs;
}

static FakeStack* GetFakeStackFastAlways() {
if (FakeStack* fs = GetTLSFakeStack())
FakeStack* fs = GetTLSFakeStack();
if (LIKELY(fs))
return fs;
return GetFakeStack();
fs = GetFakeStack();
if (LIKELY(fs))
SetTLSFakeStack(fs);
return fs;
}

static ALWAYS_INLINE uptr OnMalloc(uptr class_id, uptr size) {
Expand Down
2 changes: 1 addition & 1 deletion compiler-rt/lib/asan/asan_fake_stack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class FakeStack {
void *true_start;
};

void SetTLSFakeStack(FakeStack *fs);
void SetTLSFakeStack(FakeStack* fs);

} // namespace __asan

Expand Down
Loading