[mlir][python] Fix lit run line for openacc test #163797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test passed locally because I had a python environment with the `python` command available, but I should have used the %PYTHON lit command substitution instead.
ashermancinelli
requested review from
ftynse,
makslevental,
rolfmorel and
stellaraccident
as code owners
|
@llvm/pr-subscribers-mlir Author: Asher Mancinelli (ashermancinelli) ChangesThis test passed locally because I had a python environment with the Full diff: https://github.com/llvm/llvm-project/pull/163797.diff 1 Files Affected:
diff --git a/mlir/test/python/dialects/openacc.py b/mlir/test/python/dialects/openacc.py
index 6afdf450de239..8f2142a74c7a1 100644
--- a/mlir/test/python/dialects/openacc.py
+++ b/mlir/test/python/dialects/openacc.py
@@ -1,4 +1,4 @@
-# RUN: python %s | FileCheck %s
+# RUN: %PYTHON %s | FileCheck %s
from unittest import result
from mlir.ir import (
Context,
|
|
Merging this one-liner without an approval to get the buildbots green again - apologies! |
|
Thanks a lot for the quick fix! |
No worries - this is the standard thing to do in such cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test passed locally because I had a python environment with the
pythoncommand available, but I should have used the%PYTHONlit command substitution instead. Fixes buildbot failures from #163620.