-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[CIR]lAdd name for function type in vtable #163839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-clangir @llvm/pr-subscribers-clang Author: Adrian (y-Adrian) ChangesThis commit adds the RTTI support for function type in the vtable. Issue #163601 Full diff: https://github.com/llvm/llvm-project/pull/163839.diff 1 Files Affected:
diff --git a/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp b/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
index 1b85a530cbdd7..44919de69ae8e 100644
--- a/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
@@ -946,8 +946,7 @@ const char *vTableClassNameForType(const CIRGenModule &cgm, const Type *ty) {
case Type::FunctionNoProto:
case Type::FunctionProto:
- cgm.errorNYI("VTableClassNameForType: __function_type_info");
- break;
+ return "__ZTSN10__cxxabiv120__function_type_infoE";
case Type::Enum:
cgm.errorNYI("VTableClassNameForType: Enum");
|
case Type::FunctionProto: | ||
cgm.errorNYI("VTableClassNameForType: __function_type_info"); | ||
break; | ||
return "__ZTSN10__cxxabiv120__function_type_infoE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at ItaniumCXXABI.cpp#L3977 should it be _ZTVN10__cxxabiv120__function_type_infoE
here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. __ZTSN10__cxxabiv120__function_type_infoE
is the _typeinfo name for __cxxabiv1::__function_type_info
but what we need here is the vtable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reminder. I fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need a test added.
case Type::FunctionProto: | ||
cgm.errorNYI("VTableClassNameForType: __function_type_info"); | ||
break; | ||
return "__ZTSN10__cxxabiv120__function_type_infoE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. __ZTSN10__cxxabiv120__function_type_infoE
is the _typeinfo name for __cxxabiv1::__function_type_info
but what we need here is the vtable.
d7a38e2
to
656c03d
Compare
This commit adds the RTTI support for function type in the vtable.
Issue #163601