Skip to content

Conversation

y-Adrian
Copy link

This commit adds the RTTI support for function type in the vtable.

Issue #163601

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project labels Oct 16, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 16, 2025

@llvm/pr-subscribers-clangir

@llvm/pr-subscribers-clang

Author: Adrian (y-Adrian)

Changes

This commit adds the RTTI support for function type in the vtable.

Issue #163601


Full diff: https://github.com/llvm/llvm-project/pull/163839.diff

1 Files Affected:

  • (modified) clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp (+1-2)
diff --git a/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp b/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
index 1b85a530cbdd7..44919de69ae8e 100644
--- a/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
@@ -946,8 +946,7 @@ const char *vTableClassNameForType(const CIRGenModule &cgm, const Type *ty) {
 
   case Type::FunctionNoProto:
   case Type::FunctionProto:
-    cgm.errorNYI("VTableClassNameForType: __function_type_info");
-    break;
+    return "__ZTSN10__cxxabiv120__function_type_infoE";
 
   case Type::Enum:
     cgm.errorNYI("VTableClassNameForType: Enum");

case Type::FunctionProto:
cgm.errorNYI("VTableClassNameForType: __function_type_info");
break;
return "__ZTSN10__cxxabiv120__function_type_infoE";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at ItaniumCXXABI.cpp#L3977 should it be _ZTVN10__cxxabiv120__function_type_infoE here ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. __ZTSN10__cxxabiv120__function_type_infoE is the _typeinfo name for __cxxabiv1::__function_type_info but what we need here is the vtable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder. I fixed it.

Copy link
Contributor

@andykaylor andykaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need a test added.

case Type::FunctionProto:
cgm.errorNYI("VTableClassNameForType: __function_type_info");
break;
return "__ZTSN10__cxxabiv120__function_type_infoE";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. __ZTSN10__cxxabiv120__function_type_infoE is the _typeinfo name for __cxxabiv1::__function_type_info but what we need here is the vtable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants