[lldb][ValueObject][NFC] Remove unused SyntheticChildrenFrontEnd member #164249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These `IsValid`/`SetValid` APIs are only ever used from 1 data-formatter in the Swift LLDB fork. Since all the APIs on `SyntheticChildrenFrontEnd` are meant to be overriden, there is no good way to enforce calling `IsValid` from the base. And we should just let that 1 data-formatter manage its own `IsValid` state.
|
@llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) ChangesThese Full diff: https://github.com/llvm/llvm-project/pull/164249.diff 1 Files Affected:
diff --git a/lldb/include/lldb/DataFormatters/TypeSynthetic.h b/lldb/include/lldb/DataFormatters/TypeSynthetic.h
index b147d66def730..4c57a80ee104e 100644
--- a/lldb/include/lldb/DataFormatters/TypeSynthetic.h
+++ b/lldb/include/lldb/DataFormatters/TypeSynthetic.h
@@ -28,13 +28,9 @@ class SyntheticChildrenFrontEnd {
protected:
ValueObject &m_backend;
- void SetValid(bool valid) { m_valid = valid; }
-
- bool IsValid() { return m_valid; }
-
public:
SyntheticChildrenFrontEnd(ValueObject &backend)
- : m_backend(backend), m_valid(true) {}
+ : m_backend(backend) {}
virtual ~SyntheticChildrenFrontEnd() = default;
@@ -100,7 +96,6 @@ class SyntheticChildrenFrontEnd {
CompilerType type);
private:
- bool m_valid;
SyntheticChildrenFrontEnd(const SyntheticChildrenFrontEnd &) = delete;
const SyntheticChildrenFrontEnd &
operator=(const SyntheticChildrenFrontEnd &) = delete;
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Michael137
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 20, 2025
We removed the base-class `SyntheticChildrenFrontEnd::m_valid` member in llvm#164249. The URL formatter is the only user of this and should be able to keep track of its own validity without going through the base.
Michael137
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 20, 2025
We removed the base-class `SyntheticChildrenFrontEnd::m_valid` member in llvm#164249. The URL formatter is the only user of this and should be able to keep track of its own validity without going through the base.
adrian-prantl
approved these changes
Oct 20, 2025
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
…er (llvm#164249) These `IsValid`/`SetValid` APIs are only ever used from 1 data-formatter in the Swift LLDB fork. Since all the APIs on `SyntheticChildrenFrontEnd` are meant to be overriden, there is no good way to enforce calling `IsValid` from the base. And we should just let that 1 data-formatter manage its own `IsValid` state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
IsValid/SetValidAPIs are only ever used from 1 data-formatter in the Swift LLDB fork. Since all the APIs onSyntheticChildrenFrontEndare meant to be overriden, there is no good way to enforce callingIsValidfrom the base. And we should just let that 1 data-formatter manage its ownIsValidstate.