Skip to content

Conversation

@artagnon
Copy link
Contributor

ExpandSCEV recipes are expanded late, and SCEVToExpansion is just a cache that is not scheduled for removal.

ExpandSCEV recipes are expanded late, and SCEVToExpansion is just a
cache that is not scheduled for removal.
@llvmbot
Copy link
Member

llvmbot commented Oct 20, 2025

@llvm/pr-subscribers-llvm-transforms

@llvm/pr-subscribers-vectorizers

Author: Ramkumar Ramachandra (artagnon)

Changes

ExpandSCEV recipes are expanded late, and SCEVToExpansion is just a cache that is not scheduled for removal.


Full diff: https://github.com/llvm/llvm-project/pull/164288.diff

1 Files Affected:

  • (modified) llvm/lib/Transforms/Vectorize/VPlan.h (-2)
diff --git a/llvm/lib/Transforms/Vectorize/VPlan.h b/llvm/lib/Transforms/Vectorize/VPlan.h
index fed04eb1cbe9f..2eeaee712690a 100644
--- a/llvm/lib/Transforms/Vectorize/VPlan.h
+++ b/llvm/lib/Transforms/Vectorize/VPlan.h
@@ -4164,8 +4164,6 @@ class VPlan {
   SmallVector<VPValue *, 16> VPLiveIns;
 
   /// Mapping from SCEVs to the VPValues representing their expansions.
-  /// NOTE: This mapping is temporary and will be removed once all users have
-  /// been modeled in VPlan directly.
   DenseMap<const SCEV *, VPValue *> SCEVToExpansion;
 
   /// Blocks allocated and owned by the VPlan. They will be deleted once the

SmallVector<VPValue *, 16> VPLiveIns;

/// Mapping from SCEVs to the VPValues representing their expansions.
/// NOTE: This mapping is temporary and will be removed once all users have
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting one, originally I was a bit surprised and while trying to confirm if the TODO is still needed it turns out the while map isn't needed any longer: https://github.com/llvm/llvm-project/pull/164490/files

@artagnon artagnon closed this Oct 21, 2025
@artagnon artagnon deleted the vplan-scevexpand-stale-comment branch October 21, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants