Skip to content

Conversation

@yozhu
Copy link
Contributor

@yozhu yozhu commented Oct 20, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Oct 20, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-spirv

Author: YongKang Zhu (yozhu)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/164307.diff

1 Files Affected:

  • (modified) mlir/test/Target/SPIRV/function-decorations.mlir (+1)
diff --git a/mlir/test/Target/SPIRV/function-decorations.mlir b/mlir/test/Target/SPIRV/function-decorations.mlir
index 6098e42f063a2..ad59d01cccef4 100644
--- a/mlir/test/Target/SPIRV/function-decorations.mlir
+++ b/mlir/test/Target/SPIRV/function-decorations.mlir
@@ -1,3 +1,4 @@
+// REQUIRES: asserts
 // RUN: mlir-translate --no-implicit-module --test-spirv-roundtrip --split-input-file %s | FileCheck %s
 // RUN: mlir-translate --no-implicit-module --test-spirv-roundtrip --split-input-file --debug %s | FileCheck %s
 

@yozhu yozhu requested review from IgWod-IMG and thevinster October 20, 2025 19:14
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why this is required? If we have some code behind NDEBUG, can we make it unconditional instead?

@yozhu
Copy link
Contributor Author

yozhu commented Oct 20, 2025

Could you explain why this is required? If we have some code behind NDEBUG, can we make it unconditional instead?

When this test is run with a build that doesn't enable DEBUG, the test will fail with error message mlir-translate: Unknown command line argument '--debug'.

@yozhu yozhu changed the title [MLIR][test] Add asserts requirement to one test [MLIR][test][nfc] Add asserts requirement to one test Oct 20, 2025
@kuhar
Copy link
Member

kuhar commented Oct 20, 2025

We should probably comment out the RUN line with --debug then

@kuhar
Copy link
Member

kuhar commented Oct 20, 2025

This was resolved in #164319

@kuhar kuhar closed this Oct 20, 2025
@yozhu yozhu deleted the fixtest branch October 23, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants