[msan][test] Add tests for target("aarch64.svcount") #164315
Merged
+82
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target("aarch64.svcount") is not properly supported by MSan, and will lead to a clang crash:
```
fatal error: error in backend: Cannot implicitly convert a scalable size to a fixed-width size in `TypeSize::operator ScalarTy()`
```
This commit adds two test cases: a full test case for tracking any future improvements to the instrumentation, and a manually reduced test case to show the crash.
Forked from llvm/test/CodeGen/AArch64/sme-aarch64-svcount.ll
fmayer
approved these changes
Oct 20, 2025
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Oct 20, 2025
This shows a crash that happens because MSan tries to check the shadow
of target("aarch64.svcount").
This is the followup to
llvm#164315. This also does a
drive-by fix of those test cases, to use 'not opt' instead of XFAIL.
Forked from llvm/test/CodeGen/AArch64/sme2-intrinsics-add.ll
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Oct 21, 2025
This shows a crash that happens because MSan tries to check the shadow
of target("aarch64.svcount").
This is the followup to
llvm#164315. This also does a
drive-by fix of those test cases, to use 'not opt' instead of XFAIL.
Forked from llvm/test/CodeGen/AArch64/sme2-intrinsics-add.ll
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Oct 21, 2025
This shows a crash that happens because MSan tries to check the shadow
of target("aarch64.svcount").
This is the followup to
llvm#164315. This also does a
drive-by fix of those test cases, to use 'not opt' instead of XFAIL.
Forked from llvm/test/CodeGen/AArch64/sme2-intrinsics-add.ll
thurstond
added a commit
that referenced
this pull request
Oct 22, 2025
This shows a crash that happens because MSan tries to check the shadow
of a target("aarch64.svcount")-sized argument.
This is the followup to
#164315. This also does a
drive-by fix of those test cases, to remove FileCheck (otherwise, even
if opt passed, the test would still XFAIL because FileCheck cannot find
any CHECK: assertions).
Forked from llvm/test/CodeGen/AArch64/sme2-intrinsics-add.ll
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 22, 2025
…se (#164343)
This shows a crash that happens because MSan tries to check the shadow
of a target("aarch64.svcount")-sized argument.
This is the followup to
llvm/llvm-project#164315. This also does a
drive-by fix of those test cases, to remove FileCheck (otherwise, even
if opt passed, the test would still XFAIL because FileCheck cannot find
any CHECK: assertions).
Forked from llvm/test/CodeGen/AArch64/sme2-intrinsics-add.ll
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Oct 24, 2025
…se negative
MSan currently crashes at compile-time when it encounters target("aarch64.svcount") (e.g., llvm#164315). This patch duct-tapes MSan so that it won't crash at compile-time, and instead propagates a clean shadow (resulting in false negatives but not false positives).
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 24, 2025
… crash to MSan false negatives (#165028)
MSan currently crashes at compile-time when it encounters
target("aarch64.svcount") (e.g.,
llvm/llvm-project#164315). This patch duct-tapes
MSan so that it won't crash at compile-time, and instead propagates a
clean shadow (resulting in false negatives but not false positives).
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
…San false negatives (llvm#165028) MSan currently crashes at compile-time when it encounters target("aarch64.svcount") (e.g., llvm#164315). This patch duct-tapes MSan so that it won't crash at compile-time, and instead propagates a clean shadow (resulting in false negatives but not false positives).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target("aarch64.svcount") is not properly supported by MSan, and will lead to a crash:
This commit adds two test cases: a full test case for tracking any future improvements to the instrumentation (and also showing the crash), and a manually reduced test case to show the crash.
Forked from llvm/test/CodeGen/AArch64/sme-aarch64-svcount.ll