[Modules] Fix LLVM_ENABLE_MODULES build (NFC) #164402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileOffset.h uses uint64_t but only includes <cstdlib>, which is not specified to provide the uint64_t type. This happens to work without LLVM_ENABLE_MODULES enabled due to transitive includes from <cstdlib>. With LLVM_ENABLE_MODULES enabled, declarations from transitive includes are not visible by default, and the build fails. This fixes LLVM_ENABLE_MODULES builds by including the proper header, <cstdint>, instead.
naveen-seth
requested review from
Bigcheese,
cachemeifyoucan and
jansvoboda11
naveen-seth
changed the title
jansvoboda11
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileOffset.h uses
uint64_tbut only includes<cstdlib>, which is not specified to provide theuint64_ttype.This happens to work without
LLVM_ENABLE_MODULESenabled due to transitive includes from<cstdlib>.With
LLVM_ENABLE_MODULESenabled, declarations from transitive includes are not visible by default, and the build fails.This fixes
LLVM_ENABLE_MODULESbuilds by including the proper header,<cstdint>, instead.