Skip to content

Conversation

@paulwalker-arm
Copy link
Collaborator

@paulwalker-arm paulwalker-arm commented Oct 21, 2025

I think this is effectively an NFC patch (or at least I haven't found a way to trigger a bug from it) because PPR_p8to15 is not used by any instruction operands. If preferred I can instead remove the DecoderMethod assignment, but I figured that would cause work for if it ever starts being used.

@llvmbot
Copy link
Member

llvmbot commented Oct 21, 2025

@llvm/pr-subscribers-backend-aarch64

Author: Paul Walker (paulwalker-arm)

Changes

I think this is effectively an NFC patch (or at least I haven't found a way to trigger a bug from it) because PPR_p8to15 is not used by any instruction operands. If preferred I can instead remove the DecoderMethod assignment, but I figured that would cause work for if it ever starts being used.


Full diff: https://github.com/llvm/llvm-project/pull/164429.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AArch64/AArch64RegisterInfo.td (+1-1)
diff --git a/llvm/lib/Target/AArch64/AArch64RegisterInfo.td b/llvm/lib/Target/AArch64/AArch64RegisterInfo.td
index ef974df823100..47144c7333f7a 100644
--- a/llvm/lib/Target/AArch64/AArch64RegisterInfo.td
+++ b/llvm/lib/Target/AArch64/AArch64RegisterInfo.td
@@ -993,7 +993,7 @@ def PPR_3b : PPRClass<0, 7> { // Restricted 3 bit SVE predicate register class.
   let DecoderMethod = "DecodeSimpleRegisterClass<AArch64::PPRRegClassID, 0, 8>";
 }
 def PPR_p8to15 : PPRClass<8, 15> {
-  let DecoderMethod = "DecodeSimpleRegisterClass<AArch64::PNRRegClassID, 8, 8>";
+  let DecoderMethod = "DecodeSimpleRegisterClass<AArch64::PPRRegClassID, 8, 8>";
 }
 
 def PPRMul2 : PPRClass<0, 14, 2>;

@paulwalker-arm paulwalker-arm merged commit 128eacf into llvm:main Oct 22, 2025
12 checks passed
@paulwalker-arm paulwalker-arm deleted the sve-ppr-register-class-typo branch October 22, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants