Skip to content

[Clang] Make the AS of llvm.compiler.used & llvm.used elements addressspace(0) #164432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+45 −7
Open

[Clang] Make the AS of llvm.compiler.used & llvm.used elements addressspace(0) #164432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27c68e5
[Clang] Make the address space of llvm.compiler.used & llvm.used 0
jmmartinez Oct 21, 2025
184b601
[Review] Add test
jmmartinez Oct 22, 2025
5c45041
Merge branch 'main' into clang/llvm_compiler_used_as_0
jmmartinez Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions clang/lib/CodeGen/CodeGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3333,18 +3333,18 @@ static void emitUsed(CodeGenModule &CGM, StringRef Name,
if (List.empty())
return;

llvm::PointerType *UnqualPtr =
llvm::PointerType::getUnqual(CGM.getLLVMContext());

// Convert List to what ConstantArray needs.
SmallVector<llvm::Constant*, 8> UsedArray;
UsedArray.resize(List.size());
for (unsigned i = 0, e = List.size(); i != e; ++i) {
UsedArray[i] =
llvm::ConstantExpr::getPointerBitCastOrAddrSpaceCast(
cast<llvm::Constant>(&*List[i]), CGM.Int8PtrTy);
UsedArray[i] = llvm::ConstantExpr::getPointerBitCastOrAddrSpaceCast(
cast<llvm::Constant>(&*List[i]), UnqualPtr);
}

if (UsedArray.empty())
return;
llvm::ArrayType *ATy = llvm::ArrayType::get(CGM.Int8PtrTy, UsedArray.size());
llvm::ArrayType *ATy = llvm::ArrayType::get(UnqualPtr, UsedArray.size());

auto *GV = new llvm::GlobalVariable(
CGM.getModule(), ATy, false, llvm::GlobalValue::AppendingLinkage,
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CodeGen/embed-bitcode-marker-with-nonzero-as.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@

// CHECK: @llvm.embedded.module = private addrspace(1) constant [0 x i8] zeroinitializer, section ".llvmbc", align 1
// CHECK-NEXT: @llvm.cmdline = private addrspace(1) constant [{{[0-9]+}} x i8] c"{{.*}}", section ".llvmcmd", align 1
// CHECK-NEXT: @llvm.compiler.used = appending addrspace(1) global [5 x ptr addrspace(4)] [ptr addrspace(4) addrspacecast (ptr addrspace(1) @foo.managed to ptr addrspace(4)), ptr addrspace(4) addrspacecast (ptr addrspace(1) @foo to ptr addrspace(4)), ptr addrspace(4) addrspacecast (ptr addrspace(1) @__hip_cuid_ to ptr addrspace(4)), ptr addrspace(4) addrspacecast (ptr addrspace(1) @llvm.embedded.module to ptr addrspace(4)), ptr addrspace(4) addrspacecast (ptr addrspace(1) @llvm.cmdline to ptr addrspace(4))], section "llvm.metadata"
// CHECK-NEXT: @llvm.compiler.used = appending addrspace(1) global [5 x ptr] [ptr addrspacecast (ptr addrspace(1) @foo.managed to ptr), ptr addrspacecast (ptr addrspace(1) @foo to ptr), ptr addrspacecast (ptr addrspace(1) @__hip_cuid_ to ptr), ptr addrspacecast (ptr addrspace(1) @llvm.embedded.module to ptr), ptr addrspacecast (ptr addrspace(1) @llvm.cmdline to ptr)], section "llvm.metadata"

__attribute__((managed)) int foo = 42;
38 changes: 38 additions & 0 deletions clang/test/CodeGen/llvm_compiler_used_elements_are_unqual.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// RUN: %clang_cc1 -triple x86_64-- -emit-llvm -x c %s -o - \
// RUN: | FileCheck %s --check-prefix=X86
// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -emit-llvm -x c %s -o - \
// RUN: | FileCheck %s --check-prefix=AMDGCN
// RUN: %clang_cc1 -triple spirv64-- -emit-llvm -x c %s -o - \
// RUN: | FileCheck %s --check-prefix=SPIRV
// RUN: %clang_cc1 -triple spirv64-amd-amdhsa -emit-llvm -x c %s -o - \
// RUN: | FileCheck %s --check-prefix=SPIRV_AMD

static __attribute__((__used__)) int foo = 42;


// X86: @foo = internal global i32 42, align 4
// X86: @llvm.compiler.used = appending global [2 x ptr] [ptr @foo, ptr @bar], section "llvm.metadata"
//.
// AMDGCN: @foo = internal addrspace(1) global i32 42, align 4
// AMDGCN: @llvm.compiler.used = appending addrspace(1) global [2 x ptr] [ptr addrspacecast (ptr addrspace(1) @foo to ptr), ptr @bar], section "llvm.metadata"
//.
// SPIRV: @foo = internal global i32 42, align 4
// SPIRV: @llvm.used = appending addrspace(1) global [2 x ptr] [ptr @foo, ptr @bar], section "llvm.metadata"
//.
// SPIRV_AMD: @foo = internal addrspace(1) global i32 42, align 4
// SPIRV_AMD: @llvm.used = appending addrspace(1) global [2 x ptr] [ptr addrspacecast (ptr addrspace(1) @foo to ptr), ptr addrspacecast (ptr addrspace(4) @bar to ptr)], section "llvm.metadata"
//.
// X86-LABEL: define internal void @bar(
// X86-SAME: ) #[[ATTR0:[0-9]+]] {
//
// AMDGCN-LABEL: define internal void @bar(
// AMDGCN-SAME: ) #[[ATTR0:[0-9]+]] {
//
// SPIRV-LABEL: define internal spir_func void @bar(
// SPIRV-SAME: ) #[[ATTR0:[0-9]+]] {
//
// SPIRV_AMD-LABEL: define internal spir_func void @bar(
// SPIRV_AMD-SAME: ) addrspace(4) #[[ATTR0:[0-9]+]] {
//
static void __attribute__((__used__)) bar() {
}