Skip to content

[clang] Improve efficiency of CGDebugInfo by using PresumedLoc. #164441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
+284 −200
Closed

[clang] Improve efficiency of CGDebugInfo by using PresumedLoc. #164441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c7d2931
Emit debug info with original source location for tokens from macros …
SergejSalnikov Oct 13, 2025
2fcf4fd
Add getRefinedSpellingLoc to SourceManager.
SergejSalnikov Oct 14, 2025
5c3a08c
Minimize the amount of location expansions inside CGDebugInfo.
SergejSalnikov Oct 14, 2025
6fb3812
Add more cases to macro-info test.
SergejSalnikov Oct 14, 2025
8917ae3
Add comment for getRefinedSpellingLocation.
SergejSalnikov Oct 14, 2025
37803f0
Optimize implementation of getRefinedSpellingLocSlowCase.
SergejSalnikov Oct 14, 2025
9452437
Rename some variables.
SergejSalnikov Oct 14, 2025
0d9f8ad
Update CGDebugInfo.h
SergejSalnikov Oct 14, 2025
23fcb80
Move method comment to header file.
SergejSalnikov Oct 14, 2025
0772e07
Fix code formatting.
SergejSalnikov Oct 15, 2025
d5fca51
Reuse SourceManager.getFileLoc method
SergejSalnikov Oct 17, 2025
a44cca0
Remove non-existing method from SourceManager.h
SergejSalnikov Oct 17, 2025
040bedf
Use PresumedLoc instead of SourceLocation in CGDebugInfo.
SergejSalnikov Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions clang/lib/Basic/SourceManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,10 +917,14 @@ SourceLocation SourceManager::getSpellingLocSlowCase(SourceLocation Loc) const {

SourceLocation SourceManager::getFileLocSlowCase(SourceLocation Loc) const {
do {
if (isMacroArgExpansion(Loc))
Loc = getImmediateSpellingLoc(Loc);
else
Loc = getImmediateExpansionRange(Loc).getBegin();
const SLocEntry &Entry = getSLocEntry(getFileID(Loc));
const ExpansionInfo &ExpInfo = Entry.getExpansion();
if (ExpInfo.isMacroArgExpansion()) {
Loc = ExpInfo.getSpellingLoc().getLocWithOffset(Loc.getOffset() -
Entry.getOffset());
} else {
Loc = ExpInfo.getExpansionLocStart();
}
} while (!Loc.isFileID());
return Loc;
}
Expand Down
Loading