Skip to content

[NFCI][asm][i386/x86-64] Enable AT&T syntax explicitly #164453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

[NFCI][asm][i386/x86-64] Enable AT&T syntax explicitly #164453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler-rt/lib/asan/asan_rtl_x86_64.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "sanitizer_common/sanitizer_platform.h"

.file "asan_rtl_x86_64.S"
.att_syntax

#define NAME(n, reg, op, s, i) n##_##op##_##i##_##s##_##reg

Expand Down
4 changes: 4 additions & 0 deletions compiler-rt/lib/builtins/assembly.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,4 +337,8 @@
#endif
#endif

#if defined(__i386__) || defined(__amd64__)
.att_syntax
#endif

#endif // COMPILERRT_ASSEMBLY_H
1 change: 1 addition & 0 deletions compiler-rt/lib/hwasan/hwasan_setjmp_x86_64.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

.section .text
.file "hwasan_setjmp_x86_64.S"
.att_syntax

.global ASM_WRAPPER_NAME(setjmp)
ASM_TYPE_FUNCTION(ASM_WRAPPER_NAME(setjmp))
Expand Down
1 change: 1 addition & 0 deletions compiler-rt/lib/orc/elfnix_tls.x86-64.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

// The content of this file is x86_64-only
#if defined(__x86_64__)
.att_syntax

#define REGISTER_SAVE_SPACE_SIZE 512

Expand Down
1 change: 1 addition & 0 deletions compiler-rt/lib/orc/sysv_reenter.x86-64.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

// The content of this file is x86_64-only
#if defined(__x86_64__)
.att_syntax

// Save all GRPS except %rsp.
// This value is also subtracted from %rsp below, despite the fact that %rbp
Expand Down
2 changes: 2 additions & 0 deletions compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_i386.inc.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#include "sanitizer_common/sanitizer_asm.h"

.att_syntax

.comm _ZN14__interception10real_vforkE,4,4
.globl ASM_WRAPPER_NAME(vfork)
ASM_TYPE_FUNCTION(ASM_WRAPPER_NAME(vfork))
Expand Down
2 changes: 2 additions & 0 deletions compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_vfork_x86_64.inc.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#include "sanitizer_common/sanitizer_asm.h"

.att_syntax

.comm _ZN14__interception10real_vforkE,8,8
.globl ASM_WRAPPER_NAME(vfork)
ASM_TYPE_FUNCTION(ASM_WRAPPER_NAME(vfork))
Expand Down
2 changes: 2 additions & 0 deletions compiler-rt/lib/tsan/rtl/tsan_rtl_amd64.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

#include "sanitizer_common/sanitizer_asm.h"

.att_syntax

#if !defined(__APPLE__)
.section .text
#else
Expand Down
3 changes: 3 additions & 0 deletions libunwind/src/UnwindRegistersRestore.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
#if !defined(__USING_SJLJ_EXCEPTIONS__)

#if defined(__i386__)
.att_syntax

DEFINE_LIBUNWIND_FUNCTION(__libunwind_Registers_x86_jumpto)
#
# extern "C" void __libunwind_Registers_x86_jumpto(Registers_x86 *);
Expand Down Expand Up @@ -69,6 +71,7 @@ DEFINE_LIBUNWIND_FUNCTION(__libunwind_Registers_x86_jumpto)
# skip gs

#elif defined(__x86_64__) && !defined(__arm64ec__)
.att_syntax

DEFINE_LIBUNWIND_FUNCTION(__libunwind_Registers_x86_64_jumpto)
#
Expand Down
2 changes: 2 additions & 0 deletions libunwind/src/UnwindRegistersSave.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#if !defined(__USING_SJLJ_EXCEPTIONS__)

#if defined(__i386__)
.att_syntax

#
# extern int __unw_getcontext(unw_context_t* thread_state)
Expand Down Expand Up @@ -109,6 +110,7 @@ DEFINE_LIBUNWIND_FUNCTION("#__unw_getcontext")
.text

#elif defined(__x86_64__)
.att_syntax

#
# extern int __unw_getcontext(unw_context_t* thread_state)
Expand Down
1 change: 1 addition & 0 deletions openmp/runtime/src/z_Linux_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "kmp_config.h"

#if KMP_ARCH_X86 || KMP_ARCH_X86_64
.att_syntax

# if defined(__ELF__) && defined(__CET__) && defined(__has_include)
# if __has_include(<cet.h>)
Expand Down