Skip to content

[NFC][OpenMP] Update a test that was failing on aarch64. #164456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 22, 2025
Merged

[NFC][OpenMP] Update a test that was failing on aarch64. #164456

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
41da687
[NFC][OpenMP] Update a test that was failing on aarch64.
abhinavgaba Oct 21, 2025
462f719
Change lu to ld in printf.
abhinavgaba Oct 21, 2025
6dda3eb
Use PRIdPTR instead of ld in printf.
abhinavgaba Oct 21, 2025
ce2ce93
Clang-format
abhinavgaba Oct 21, 2025
03aec33
Merge remote-tracking branch 'upstream/main' into remove-checks-for-c…
abhinavgaba Oct 21, 2025
914ebac
Use ptrdiff
abhinavgaba Oct 21, 2025
d1648bf
Remove the CHECK for offset comparison.
abhinavgaba Oct 22, 2025
73fa6bb
Remove unintentionally added XFAIL, while also having updated the CHECK.
abhinavgaba Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ...ad/test/mapping/use_device_addr/target_data_use_device_addr_class_member_ref_with_map.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ struct ST {
int m = 0;

void f6() {
uintptr_t offset = (uintptr_t)&d - n;
ptrdiff_t offset = (char *)&d - ((char *)(uintptr_t)n);
#pragma omp target data map(to : m, d)
{
void *mapped_ptr = omp_get_mapped_ptr(&d, omp_get_default_device());
Expand All @@ -34,11 +34,15 @@ struct ST {
// ref/attach modifiers:
// &ref_ptee(this[0].[d])), &ref_ptee(this[0].d), TO | FROM
// &ref_ptr(this[0].d), &ref_ptee(this[0].d), 4, ATTACH
// EXPECTED: 1 0
// CHECK: 0 1
printf("%d %d\n", &d == mapped_ptr,
(uintptr_t)&d == (uintptr_t)mapped_ptr - offset);
// EXPECTED: 1
// CHECK-NEXT: 0
printf("%d\n", &d == mapped_ptr);
ptrdiff_t offset_device = (char *)mapped_ptr - (char *)&d;
printf("offset = %td (%p), offset_device = %td (%p)\n", offset,
(void *)offset, offset_device, (void *)offset_device);
printf("mapped_ptr = %p, device_addr = %p, ", mapped_ptr, &d);
}
printf("host_addr = %p\n", &d);
}
}
};
Expand Down
Loading