[NFC][GlobPattern] Add doc strings to prefix/suffix methods #164514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6
Created using spr 1.3.6 [skip ci]
|
@llvm/pr-subscribers-llvm-support Author: Vitaly Buka (vitalybuka) ChangesFull diff: https://github.com/llvm/llvm-project/pull/164514.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Support/GlobPattern.h b/llvm/include/llvm/Support/GlobPattern.h
index 09be8343a6ef2..230898edf1881 100644
--- a/llvm/include/llvm/Support/GlobPattern.h
+++ b/llvm/include/llvm/Support/GlobPattern.h
@@ -72,7 +72,12 @@ class GlobPattern {
return SubGlobs[0].getPat() == "*";
}
+ // The followind functions are just shortcuts for faster matching. They are
+ // conservative to simplify implementations.
+
+ // Returns plain prefix of the pattern.
StringRef prefix() const { return Pattern.take_front(PrefixSize); }
+ // Returns plain suffix of the pattern.
StringRef suffix() const { return Pattern.take_back(SuffixSize); }
private:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation strings to the prefix() and suffix() methods in the GlobPattern class to clarify their purpose as optimization shortcuts for pattern matching.
Key Changes
- Added a general comment explaining that the following functions are shortcuts for faster matching with conservative implementations
- Added individual doc comments for the
prefix()andsuffix()methods
vitalybuka
changed the title
vitalybuka
changed the title
Created using spr 1.3.7 [skip ci]
fmayer
changed the title
fmayer
approved these changes
Oct 22, 2025
Created using spr 1.3.7 [skip ci]
vitalybuka
changed the base branch from
users/vitalybuka/spr/main.nfcglobpattern-add-doc-strings-to-preffixsuffux-methods
to
main
vitalybuka
deleted the
users/vitalybuka/spr/nfcglobpattern-add-doc-strings-to-preffixsuffux-methods
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/22173 Here is the relevant piece of the build log for the reference |
mikolaj-pirog
pushed a commit
to mikolaj-pirog/llvm-project
that referenced
this pull request
Oct 23, 2025
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.