[Docs] Clarify the brace policy for if/else/loop statements #164570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, the five-paragraph section is unclear about exactly when to use and not to use braces. Specifically, the first paragraph suggests omitting braces, and then subsequent paragraphs carve out exceptions. At the end, it's unclear what situations remain for omitting braces. This patch overhauls the text for readability. Specifically, it first describes when to omit braces and then lists cases where we should retain braces.
tgymnich
approved these changes
Oct 22, 2025
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
) Without this patch, the five-paragraph section is unclear about exactly when to use and not to use braces. Specifically, the first paragraph suggests omitting braces, and then subsequent paragraphs carve out exceptions. At the end, it's unclear what situations remain for omitting braces. This patch overhauls the text for readability. Specifically, it first describes when to omit braces and then lists cases where we should retain braces.
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
) Without this patch, the five-paragraph section is unclear about exactly when to use and not to use braces. Specifically, the first paragraph suggests omitting braces, and then subsequent paragraphs carve out exceptions. At the end, it's unclear what situations remain for omitting braces. This patch overhauls the text for readability. Specifically, it first describes when to omit braces and then lists cases where we should retain braces.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
) Without this patch, the five-paragraph section is unclear about exactly when to use and not to use braces. Specifically, the first paragraph suggests omitting braces, and then subsequent paragraphs carve out exceptions. At the end, it's unclear what situations remain for omitting braces. This patch overhauls the text for readability. Specifically, it first describes when to omit braces and then lists cases where we should retain braces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, the five-paragraph section is unclear about
exactly when to use and not to use braces. Specifically, the first
paragraph suggests omitting braces, and then subsequent paragraphs
carve out exceptions. At the end, it's unclear what situations remain
for omitting braces.
This patch overhauls the text for readability. Specifically, it first
describes when to omit braces and then lists cases where we should
retain braces.