Skip to content

[polly] Remove unsafe-fp-math uses (NFC) #164603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

[polly] Remove unsafe-fp-math uses (NFC) #164603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4772514
[polly] Remove unsafe-fp-math uses (NFC)
paperchalice Oct 22, 2025
ffc0635
Remove attributes section, suggested by nikic
paperchalice Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions polly/docs/experiments/matmul/matmul.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ target triple = "x86_64-unknown-linux-gnu"
@.str.1 = private unnamed_addr constant [2 x i8] c"\0A\00", align 1

; Function Attrs: noinline nounwind uwtable
define dso_local void @init_array() #0 {
define dso_local void @init_array() {
entry:
%i = alloca i32, align 4
%j = alloca i32, align 4
Expand Down Expand Up @@ -88,7 +88,7 @@ for.end19: ; preds = %for.cond
}

; Function Attrs: noinline nounwind uwtable
define dso_local void @print_array() #0 {
define dso_local void @print_array() {
entry:
%i = alloca i32, align 4
%j = alloca i32, align 4
Expand Down Expand Up @@ -154,10 +154,10 @@ for.end12: ; preds = %for.cond
ret void
}

declare dso_local i32 @fprintf(%struct._IO_FILE*, i8*, ...) #1
declare dso_local i32 @fprintf(%struct._IO_FILE*, i8*, ...)

; Function Attrs: noinline nounwind uwtable
define dso_local i32 @main() #0 {
define dso_local i32 @main() {
entry:
%retval = alloca i32, align 4
%i = alloca i32, align 4
Expand Down Expand Up @@ -261,9 +261,6 @@ for.end30: ; preds = %for.cond
ret i32 0
}

attributes #0 = { noinline nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }

!llvm.module.flags = !{!0}
!llvm.ident = !{!1}

Expand Down
18 changes: 6 additions & 12 deletions polly/docs/experiments/matmul/matmul.normalopt.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ target triple = "x86_64-unknown-linux-gnu"
@C = common dso_local local_unnamed_addr global [1536 x [1536 x float]] zeroinitializer, align 16

; Function Attrs: noinline norecurse nounwind uwtable writeonly
define dso_local void @init_array() local_unnamed_addr #0 {
define dso_local void @init_array() local_unnamed_addr {
entry:
br label %for.cond1.preheader

Expand Down Expand Up @@ -60,7 +60,7 @@ for.end19: ; preds = %for.inc17
}

; Function Attrs: noinline nounwind uwtable
define dso_local void @print_array() local_unnamed_addr #1 {
define dso_local void @print_array() local_unnamed_addr {
entry:
br label %for.cond1.preheader

Expand All @@ -75,7 +75,7 @@ for.body3: ; preds = %for.inc, %for.cond1
%arrayidx5 = getelementptr inbounds [1536 x [1536 x float]], [1536 x [1536 x float]]* @C, i64 0, i64 %indvars.iv6, i64 %indvars.iv
%2 = load float, float* %arrayidx5, align 4
%conv = fpext float %2 to double
%call = tail call i32 (%struct._IO_FILE*, i8*, ...) @fprintf(%struct._IO_FILE* %1, i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str, i64 0, i64 0), double %conv) #4
%call = tail call i32 (%struct._IO_FILE*, i8*, ...) @fprintf(%struct._IO_FILE* %1, i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str, i64 0, i64 0), double %conv)
%3 = trunc i64 %indvars.iv to i32
%rem = urem i32 %3, 80
%cmp6 = icmp eq i32 %rem, 79
Expand Down Expand Up @@ -103,10 +103,10 @@ for.end12: ; preds = %for.end
}

; Function Attrs: nounwind
declare dso_local i32 @fprintf(%struct._IO_FILE* nocapture, i8* nocapture readonly, ...) local_unnamed_addr #2
declare dso_local i32 @fprintf(%struct._IO_FILE* nocapture, i8* nocapture readonly, ...) local_unnamed_addr

; Function Attrs: noinline norecurse nounwind uwtable
define dso_local i32 @main() local_unnamed_addr #3 {
define dso_local i32 @main() local_unnamed_addr {
entry:
tail call void @init_array()
br label %for.cond1.preheader
Expand Down Expand Up @@ -164,13 +164,7 @@ for.end30: ; preds = %for.inc28
}

; Function Attrs: nounwind
declare i32 @fputc(i32, %struct._IO_FILE* nocapture) local_unnamed_addr #4

attributes #0 = { noinline norecurse nounwind uwtable writeonly "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #2 = { nounwind "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #3 = { noinline norecurse nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #4 = { nounwind }
declare i32 @fputc(i32, %struct._IO_FILE* nocapture) local_unnamed_addr

!llvm.module.flags = !{!0}
!llvm.ident = !{!1}
Expand Down
45 changes: 19 additions & 26 deletions polly/docs/experiments/matmul/matmul.polly.interchanged+tiled+vector+openmp.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ target triple = "x86_64-unknown-linux-gnu"
@C = common dso_local local_unnamed_addr global [1536 x [1536 x float]] zeroinitializer, align 16

; Function Attrs: noinline nounwind uwtable
define dso_local void @init_array() local_unnamed_addr #0 {
define dso_local void @init_array() local_unnamed_addr {
entry:
%polly.par.userContext = alloca {}, align 8
%polly.par.userContext1 = bitcast {}* %polly.par.userContext to i8*
call void @GOMP_parallel_loop_runtime_start(void (i8*)* nonnull @init_array_polly_subfn, i8* nonnull %polly.par.userContext1, i32 0, i64 0, i64 1536, i64 1) #3
call void @init_array_polly_subfn(i8* nonnull %polly.par.userContext1) #3
call void @GOMP_parallel_end() #3
call void @GOMP_parallel_loop_runtime_start(void (i8*)* nonnull @init_array_polly_subfn, i8* nonnull %polly.par.userContext1, i32 0, i64 0, i64 1536, i64 1)
call void @init_array_polly_subfn(i8* nonnull %polly.par.userContext1)
call void @GOMP_parallel_end()
ret void
}

; Function Attrs: noinline nounwind uwtable
define dso_local void @print_array() local_unnamed_addr #1 {
define dso_local void @print_array() local_unnamed_addr {
entry:
br label %for.cond1.preheader

Expand All @@ -39,7 +39,7 @@ for.body3: ; preds = %for.inc, %for.cond1
%arrayidx5 = getelementptr inbounds [1536 x [1536 x float]], [1536 x [1536 x float]]* @C, i64 0, i64 %indvars.iv6, i64 %indvars.iv
%2 = load float, float* %arrayidx5, align 4
%conv = fpext float %2 to double
%call = tail call i32 (%struct._IO_FILE*, i8*, ...) @fprintf(%struct._IO_FILE* %1, i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str, i64 0, i64 0), double %conv) #3
%call = tail call i32 (%struct._IO_FILE*, i8*, ...) @fprintf(%struct._IO_FILE* %1, i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str, i64 0, i64 0), double %conv)
%3 = trunc i64 %indvars.iv to i32
%rem = urem i32 %3, 80
%cmp6 = icmp eq i32 %rem, 79
Expand Down Expand Up @@ -67,27 +67,27 @@ for.end12: ; preds = %for.end
}

; Function Attrs: nounwind
declare dso_local i32 @fprintf(%struct._IO_FILE* nocapture, i8* nocapture readonly, ...) local_unnamed_addr #2
declare dso_local i32 @fprintf(%struct._IO_FILE* nocapture, i8* nocapture readonly, ...) local_unnamed_addr

; Function Attrs: noinline nounwind uwtable
define dso_local i32 @main() local_unnamed_addr #0 {
define dso_local i32 @main() local_unnamed_addr {
entry:
%polly.par.userContext3 = alloca {}, align 8
tail call void @init_array()
%polly.par.userContext1 = bitcast {}* %polly.par.userContext3 to i8*
call void @GOMP_parallel_loop_runtime_start(void (i8*)* nonnull @main_polly_subfn, i8* nonnull %polly.par.userContext1, i32 0, i64 0, i64 1536, i64 1) #3
call void @main_polly_subfn(i8* nonnull %polly.par.userContext1) #3
call void @GOMP_parallel_end() #3
call void @GOMP_parallel_loop_runtime_start(void (i8*)* nonnull @main_polly_subfn_1, i8* nonnull %polly.par.userContext1, i32 0, i64 0, i64 1536, i64 64) #3
call void @main_polly_subfn_1(i8* nonnull %polly.par.userContext1) #3
call void @GOMP_parallel_end() #3
call void @GOMP_parallel_loop_runtime_start(void (i8*)* nonnull @main_polly_subfn, i8* nonnull %polly.par.userContext1, i32 0, i64 0, i64 1536, i64 1)
call void @main_polly_subfn(i8* nonnull %polly.par.userContext1)
call void @GOMP_parallel_end()
call void @GOMP_parallel_loop_runtime_start(void (i8*)* nonnull @main_polly_subfn_1, i8* nonnull %polly.par.userContext1, i32 0, i64 0, i64 1536, i64 64)
call void @main_polly_subfn_1(i8* nonnull %polly.par.userContext1)
call void @GOMP_parallel_end()
ret i32 0
}

; Function Attrs: nounwind
declare i32 @fputc(i32, %struct._IO_FILE* nocapture) local_unnamed_addr #3
declare i32 @fputc(i32, %struct._IO_FILE* nocapture) local_unnamed_addr

define internal void @init_array_polly_subfn(i8* nocapture readnone %polly.par.userContext) #4 {
define internal void @init_array_polly_subfn(i8* nocapture readnone %polly.par.userContext) {
polly.par.setup:
%polly.par.LBPtr = alloca i64, align 8
%polly.par.UBPtr = alloca i64, align 8
Expand Down Expand Up @@ -146,7 +146,7 @@ declare void @GOMP_parallel_loop_runtime_start(void (i8*)*, i8*, i32, i64, i64,

declare void @GOMP_parallel_end() local_unnamed_addr

define internal void @main_polly_subfn(i8* nocapture readnone %polly.par.userContext) #4 {
define internal void @main_polly_subfn(i8* nocapture readnone %polly.par.userContext) {
polly.par.setup:
%polly.par.LBPtr = alloca i64, align 8
%polly.par.UBPtr = alloca i64, align 8
Expand Down Expand Up @@ -175,7 +175,7 @@ polly.par.loadIVBounds: ; preds = %polly.par.setup, %p
br i1 %7, label %polly.par.exit, label %polly.par.loadIVBounds
}

define internal void @main_polly_subfn_1(i8* nocapture readnone %polly.par.userContext) #4 {
define internal void @main_polly_subfn_1(i8* nocapture readnone %polly.par.userContext) {
polly.par.setup:
%polly.par.LBPtr = alloca i64, align 8
%polly.par.UBPtr = alloca i64, align 8
Expand Down Expand Up @@ -363,14 +363,7 @@ vector.ph: ; preds = %polly.loop_header14
}

; Function Attrs: argmemonly nounwind
declare void @llvm.memset.p0i8.i64(i8* nocapture writeonly, i8, i64, i1) #5

attributes #0 = { noinline nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "polly-optimized" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #2 = { nounwind "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #3 = { nounwind }
attributes #4 = { "polly.skip.fn" }
attributes #5 = { argmemonly nounwind }
declare void @llvm.memset.p0i8.i64(i8* nocapture writeonly, i8, i64, i1)

!llvm.module.flags = !{!0}
!llvm.ident = !{!1}
Expand Down
21 changes: 7 additions & 14 deletions polly/docs/experiments/matmul/matmul.polly.interchanged+tiled+vector.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ target triple = "x86_64-unknown-linux-gnu"
@C = common dso_local local_unnamed_addr global [1536 x [1536 x float]] zeroinitializer, align 16

; Function Attrs: noinline norecurse nounwind uwtable writeonly
define dso_local void @init_array() local_unnamed_addr #0 {
define dso_local void @init_array() local_unnamed_addr {
entry:
br label %polly.loop_header

Expand Down Expand Up @@ -61,7 +61,7 @@ polly.loop_header1: ; preds = %polly.loop_header1,
}

; Function Attrs: noinline nounwind uwtable
define dso_local void @print_array() local_unnamed_addr #1 {
define dso_local void @print_array() local_unnamed_addr {
entry:
br label %for.cond1.preheader

Expand All @@ -76,7 +76,7 @@ for.body3: ; preds = %for.inc, %for.cond1
%arrayidx5 = getelementptr inbounds [1536 x [1536 x float]], [1536 x [1536 x float]]* @C, i64 0, i64 %indvars.iv6, i64 %indvars.iv
%2 = load float, float* %arrayidx5, align 4
%conv = fpext float %2 to double
%call = tail call i32 (%struct._IO_FILE*, i8*, ...) @fprintf(%struct._IO_FILE* %1, i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str, i64 0, i64 0), double %conv) #4
%call = tail call i32 (%struct._IO_FILE*, i8*, ...) @fprintf(%struct._IO_FILE* %1, i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str, i64 0, i64 0), double %conv)
%3 = trunc i64 %indvars.iv to i32
%rem = urem i32 %3, 80
%cmp6 = icmp eq i32 %rem, 79
Expand Down Expand Up @@ -104,10 +104,10 @@ for.end12: ; preds = %for.end
}

; Function Attrs: nounwind
declare dso_local i32 @fprintf(%struct._IO_FILE* nocapture, i8* nocapture readonly, ...) local_unnamed_addr #2
declare dso_local i32 @fprintf(%struct._IO_FILE* nocapture, i8* nocapture readonly, ...) local_unnamed_addr

; Function Attrs: noinline norecurse nounwind uwtable
define dso_local i32 @main() local_unnamed_addr #3 {
define dso_local i32 @main() local_unnamed_addr {
entry:
tail call void @init_array()
call void @llvm.memset.p0i8.i64(i8* align 16 bitcast ([1536 x [1536 x float]]* @C to i8*), i8 0, i64 9437184, i1 false)
Expand Down Expand Up @@ -282,17 +282,10 @@ vector.ph: ; preds = %polly.loop_header26
}

; Function Attrs: nounwind
declare i32 @fputc(i32, %struct._IO_FILE* nocapture) local_unnamed_addr #4
declare i32 @fputc(i32, %struct._IO_FILE* nocapture) local_unnamed_addr

; Function Attrs: argmemonly nounwind
declare void @llvm.memset.p0i8.i64(i8* nocapture writeonly, i8, i64, i1) #5

attributes #0 = { noinline norecurse nounwind uwtable writeonly "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "polly-optimized" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #2 = { nounwind "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #3 = { noinline norecurse nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "polly-optimized" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #4 = { nounwind }
attributes #5 = { argmemonly nounwind }
declare void @llvm.memset.p0i8.i64(i8* nocapture writeonly, i8, i64, i1)

!llvm.module.flags = !{!0}
!llvm.ident = !{!1}
Expand Down
Loading