-
Notifications
You must be signed in to change notification settings - Fork 15k
[LIT][Cygwin] Mark ulimit -n unsupported for Cygwin
#164604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@llvm/pr-subscribers-testing-tools Author: Tomohiro Kashiwada (kikairoya) ChangesCygwin doesn't support Full diff: https://github.com/llvm/llvm-project/pull/164604.diff 2 Files Affected:
diff --git a/llvm/utils/lit/lit/run.py b/llvm/utils/lit/lit/run.py
index 62070e824e87f..5830b21be6b0f 100644
--- a/llvm/utils/lit/lit/run.py
+++ b/llvm/utils/lit/lit/run.py
@@ -137,6 +137,6 @@ def _increase_process_limit(self):
"Raised process limit from %d to %d" % (soft_limit, desired_limit)
)
except Exception as ex:
- # Warn, unless this is Windows or z/OS, in which case this is expected.
- if os.name != "nt" and platform.system() != "OS/390":
+ # Warn, unless this is Windows, z/OS, or Cygwin in which case this is expected.
+ if os.name != "nt" and platform.system() != "OS/390" and platform.sys.platform != "cygwin":
self.lit_config.warning("Failed to raise process limit: %s" % ex)
diff --git a/llvm/utils/lit/tests/shtest-ulimit.py b/llvm/utils/lit/tests/shtest-ulimit.py
index 9a8febd3333c4..c3d51067e8936 100644
--- a/llvm/utils/lit/tests/shtest-ulimit.py
+++ b/llvm/utils/lit/tests/shtest-ulimit.py
@@ -3,7 +3,7 @@
# ulimit does not work on non-POSIX platforms.
# Solaris for some reason does not respect ulimit -n, so mark it unsupported
# as well.
-# UNSUPPORTED: system-windows, system-solaris
+# UNSUPPORTED: system-windows, system-cygwin, system-solaris
# RUN: not %{lit} -a -v %{inputs}/shtest-ulimit --order=lexical | FileCheck %s
|
|
✅ With the latest revision this PR passed the Python code formatter. |
Cygwin doesn't support `ulimit -n` because Windows doesn't provide such functionality.
4407b0b to
c1572a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cygwin doesn't support `ulimit -n` because Windows doesn't provide such functionality.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/41678 Here is the relevant piece of the build log for the reference |
Cygwin doesn't support `ulimit -n` because Windows doesn't provide such functionality.
Cygwin doesn't support `ulimit -n` because Windows doesn't provide such functionality.
Cygwin doesn't support `ulimit -n` because Windows doesn't provide such functionality.
Cygwin doesn't support
ulimit -nbecause Windows doesn't provide such functionality.