[ARM][AArch64] Move TestInputs to Inputs #164633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works better with the custom lit runner that we use internally in Google. Test inputs require special handling and "Inputs" is the standard directory name used for lit tests.
|
@llvm/pr-subscribers-lto Author: Walter Lee (googlewalt) ChangesThis works better with the custom lit runner that we use internally in Google. Test inputs require special handling and "Inputs" is the standard directory name used for lit tests. Fixes internal issue with #86212. Full diff: https://github.com/llvm/llvm-project/pull/164633.diff 6 Files Affected:
diff --git a/llvm/test/LTO/AArch64/TestInputs/bar.ll b/llvm/test/LTO/AArch64/Inputs/bar.ll
similarity index 100%
rename from llvm/test/LTO/AArch64/TestInputs/bar.ll
rename to llvm/test/LTO/AArch64/Inputs/bar.ll
diff --git a/llvm/test/LTO/AArch64/TestInputs/fiz.ll b/llvm/test/LTO/AArch64/Inputs/fiz.ll
similarity index 100%
rename from llvm/test/LTO/AArch64/TestInputs/fiz.ll
rename to llvm/test/LTO/AArch64/Inputs/fiz.ll
diff --git a/llvm/test/LTO/AArch64/TestInputs/foo.ll b/llvm/test/LTO/AArch64/Inputs/foo.ll
similarity index 100%
rename from llvm/test/LTO/AArch64/TestInputs/foo.ll
rename to llvm/test/LTO/AArch64/Inputs/foo.ll
diff --git a/llvm/test/LTO/AArch64/TestInputs/old.ll b/llvm/test/LTO/AArch64/Inputs/old.ll
similarity index 100%
rename from llvm/test/LTO/AArch64/TestInputs/old.ll
rename to llvm/test/LTO/AArch64/Inputs/old.ll
diff --git a/llvm/test/LTO/AArch64/link-branch-target-enforcement.ll b/llvm/test/LTO/AArch64/link-branch-target-enforcement.ll
index aef8907c03411..20254de995f73 100644
--- a/llvm/test/LTO/AArch64/link-branch-target-enforcement.ll
+++ b/llvm/test/LTO/AArch64/link-branch-target-enforcement.ll
@@ -2,7 +2,7 @@
;; be mixed.
;;
; RUN: llvm-as %s -o %t1.bc
-; RUN: llvm-as %p/TestInputs/foo.ll -o %t2.bc
+; RUN: llvm-as %p/Inputs/foo.ll -o %t2.bc
; RUN: llvm-lto -exported-symbol main \
; RUN: -exported-symbol foo_on \
; RUN: -filetype=obj \
diff --git a/llvm/test/LTO/AArch64/link-sign-return-address.ll b/llvm/test/LTO/AArch64/link-sign-return-address.ll
index df6276f32b6f1..331e481b69e43 100644
--- a/llvm/test/LTO/AArch64/link-sign-return-address.ll
+++ b/llvm/test/LTO/AArch64/link-sign-return-address.ll
@@ -2,10 +2,10 @@
;; be mixed.
;
; RUN: llvm-as %s -o %t1.bc
-; RUN: llvm-as %p/TestInputs/foo.ll -o %t2.bc
-; RUN: llvm-as %p/TestInputs/fiz.ll -o %t3.bc
-; RUN: llvm-as %p/TestInputs/bar.ll -o %t4.bc
-; RUN: llvm-as %p/TestInputs/old.ll -o %t5.bc
+; RUN: llvm-as %p/Inputs/foo.ll -o %t2.bc
+; RUN: llvm-as %p/Inputs/fiz.ll -o %t3.bc
+; RUN: llvm-as %p/Inputs/bar.ll -o %t4.bc
+; RUN: llvm-as %p/Inputs/old.ll -o %t5.bc
; RUN: llvm-lto -exported-symbol main \
; RUN: -exported-symbol foo_on \
; RUN: -exported-symbol foo_off \
|
googlewalt
changed the title
boomanaiden154
approved these changes
Oct 22, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/25706 Here is the relevant piece of the build log for the reference |
|
I don't think this PR actually caused the issue found by the bots (at least, I don't see how it could), but the bot issue is real and impacting precommit CI: #162662 (comment) CC @lhames as the ORC expert to make sure we get eyeballs on this. |
|
It looks like a flake. The postcommit builders that test the premerge configuration have not been consistently red. |
Ah good to know! I suspected that might be the case, but wasn't confident. Thank you! |
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
It's standard in LLVM to have test inputs be in "Inputs". See https://llvm.org/docs/TestingGuide.html#extra-files. Fixes internal issue with llvm#86212.
|
Belatedly -- Yep, definitely a flake! Sorry for the noise. |
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
It's standard in LLVM to have test inputs be in "Inputs". See https://llvm.org/docs/TestingGuide.html#extra-files. Fixes internal issue with llvm#86212.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
It's standard in LLVM to have test inputs be in "Inputs". See https://llvm.org/docs/TestingGuide.html#extra-files. Fixes internal issue with llvm#86212.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's standard in LLVM to have test inputs be in "Inputs". See https://llvm.org/docs/TestingGuide.html#extra-files.
Fixes internal issue with #86212.