Skip to content

[ADT] Simplify AddInteger overloads in FoldingSetNodeID (NFC) #164753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

[ADT] Simplify AddInteger overloads in FoldingSetNodeID (NFC) #164753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions llvm/include/llvm/ADT/FoldingSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,14 @@ class FoldingSetNodeID {
/// Use a SmallVector to avoid a heap allocation in the common case.
SmallVector<unsigned, 32> Bits;

template <typename T> void AddIntegerImpl(T I) {
static_assert(std::is_integral_v<T> && sizeof(T) <= sizeof(unsigned) * 2,
"T must be an integer type no wider than 64 bits");
Bits.push_back(static_cast<unsigned>(I));
if constexpr (sizeof(unsigned) < sizeof(T))
Bits.push_back(static_cast<unsigned long long>(I) >> 32);
}

public:
FoldingSetNodeID() = default;

Expand All @@ -348,24 +356,12 @@ class FoldingSetNodeID {
"unexpected pointer size");
AddInteger(reinterpret_cast<uintptr_t>(Ptr));
}
void AddInteger(signed I) { Bits.push_back(I); }
void AddInteger(unsigned I) { Bits.push_back(I); }
void AddInteger(long I) { AddInteger((unsigned long)I); }
void AddInteger(unsigned long I) {
if (sizeof(long) == sizeof(int))
AddInteger(unsigned(I));
else if (sizeof(long) == sizeof(long long)) {
AddInteger((unsigned long long)I);
} else {
llvm_unreachable("unexpected sizeof(long)");
}
}
void AddInteger(long long I) { AddInteger((unsigned long long)I); }
void AddInteger(unsigned long long I) {
AddInteger(unsigned(I));
AddInteger(unsigned(I >> 32));
}

void AddInteger(signed I) { AddIntegerImpl(I); }
void AddInteger(unsigned I) { AddIntegerImpl(I); }
void AddInteger(long I) { AddIntegerImpl(I); }
void AddInteger(unsigned long I) { AddIntegerImpl(I); }
void AddInteger(long long I) { AddIntegerImpl(I); }
void AddInteger(unsigned long long I) { AddIntegerImpl(I); }
void AddBoolean(bool B) { AddInteger(B ? 1U : 0U); }
LLVM_ABI void AddString(StringRef String);
LLVM_ABI void AddNodeID(const FoldingSetNodeID &ID);
Expand Down