Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Oct 23, 2025

@llvm/pr-subscribers-llvm-adt

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/164754.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ADT/IndexedMap.h (+2-2)
diff --git a/llvm/include/llvm/ADT/IndexedMap.h b/llvm/include/llvm/ADT/IndexedMap.h
index 638fe14bfe797..55935a7afdab4 100644
--- a/llvm/include/llvm/ADT/IndexedMap.h
+++ b/llvm/include/llvm/ADT/IndexedMap.h
@@ -44,11 +44,11 @@ class IndexedMap {
   using StorageT = SmallVector<T, 0>;
 
   StorageT storage_;
-  T nullVal_;
+  T nullVal_ = T();
   ToIndexT toIndex_;
 
 public:
-  IndexedMap() : nullVal_(T()) {}
+  IndexedMap() = default;
 
   explicit IndexedMap(const T &val) : nullVal_(val) {}
 

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the member naming in this class is unusual for llvm

@kazutakahirata kazutakahirata merged commit d548b0d into llvm:main Oct 23, 2025
12 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20251022_ADT_IndexedMap_ctor branch October 23, 2025 06:42
mikolaj-pirog pushed a commit to mikolaj-pirog/llvm-project that referenced this pull request Oct 23, 2025
dvbuka pushed a commit to dvbuka/llvm-project that referenced this pull request Oct 27, 2025
Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants