[lldb][test] skip Lua tests when the Lua interpreter is not found #164793
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-lldb Author: Vincent Palatin (vpalatin) ChangesWhen Swig is installed but not any Lua interpreter, the cmake script in Ensure that in this case we are skipping the Lua tests requiring the interpreter. Full diff: https://github.com/llvm/llvm-project/pull/164793.diff 1 Files Affected:
diff --git a/lldb/test/API/lua_api/TestLuaAPI.py b/lldb/test/API/lua_api/TestLuaAPI.py
index 4ac795d696425..41d7873575a3d 100644
--- a/lldb/test/API/lua_api/TestLuaAPI.py
+++ b/lldb/test/API/lua_api/TestLuaAPI.py
@@ -158,7 +158,11 @@ def get_tests(self):
return tests
def test_lua_api(self):
- if "LUA_EXECUTABLE" not in os.environ or len(os.environ["LUA_EXECUTABLE"]) == 0:
+ if (
+ "LUA_EXECUTABLE" not in os.environ
+ or len(os.environ["LUA_EXECUTABLE"]) == 0
+ or "NOTFOUND" in os.environ["LUA_EXECUTABLE"]
+ ):
self.skipTest("Lua API tests could not find Lua executable.")
return
lua_executable = os.environ["LUA_EXECUTABLE"]
|
lldb/test/API/lua_api/TestLuaAPI.py
Outdated
| if ( | ||
| "LUA_EXECUTABLE" not in os.environ | ||
| or len(os.environ["LUA_EXECUTABLE"]) == 0 | ||
| or "NOTFOUND" in os.environ["LUA_EXECUTABLE"] | ||
| ): |
There was a problem hiding this comment.
How about we check if os.path.exists(os.environ["LUA_EXECUTABLE"]) to cover both cases?
There was a problem hiding this comment.
yes, it's a nicest and more generic way, I will update the patch.
By the way, while verifying the patch for the maybe-exotic corner case, I noticed that LUAANDSWIG_FOUND is incorrectly defined (to 1) too as the find_package_handle_standard_args(LuaAndSwig call in lldb/cmake/modules/FindLuaAndSwig.cmake is not checking the LUA_EXECUTABLE variable (which is LUA_EXECUTABLE-NOTFOUND in this case. I think it is worth adding too.
When Swig is installed but not any Lua interpreter, the cmake script in `lldb/cmake/modules/FindLuaAndSwig.cmake` will execute `find_program(LUA_EXECUTABLE, ...)` and this will set the `LUA_EXECUTABLE` variable to `LUA_EXECUTABLE-NOTFOUND`. Ensure that in this case we are skipping the Lua tests requiring the interpreter and the `LUAANDSWIG_FOUND` is not set.
vpalatin
force-pushed
the
lldb-lua-no-found
branch
from
08eb8ef to
4e9d7a6
Compare
|
@vpalatin Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
…vm#164793) When SWIG is installed but not any Lua interpreter, the cmake script in `lldb/cmake/modules/FindLuaAndSwig.cmake` will execute `find_program(LUA_EXECUTABLE, ...)` and this will set the `LUA_EXECUTABLE` variable to `LUA_EXECUTABLE-NOTFOUND`. Ensure that in this case we are skipping the Lua tests requiring the interpreter.
…vm#164793) When SWIG is installed but not any Lua interpreter, the cmake script in `lldb/cmake/modules/FindLuaAndSwig.cmake` will execute `find_program(LUA_EXECUTABLE, ...)` and this will set the `LUA_EXECUTABLE` variable to `LUA_EXECUTABLE-NOTFOUND`. Ensure that in this case we are skipping the Lua tests requiring the interpreter.
…vm#164793) When SWIG is installed but not any Lua interpreter, the cmake script in `lldb/cmake/modules/FindLuaAndSwig.cmake` will execute `find_program(LUA_EXECUTABLE, ...)` and this will set the `LUA_EXECUTABLE` variable to `LUA_EXECUTABLE-NOTFOUND`. Ensure that in this case we are skipping the Lua tests requiring the interpreter.
…vm#164793) When SWIG is installed but not any Lua interpreter, the cmake script in `lldb/cmake/modules/FindLuaAndSwig.cmake` will execute `find_program(LUA_EXECUTABLE, ...)` and this will set the `LUA_EXECUTABLE` variable to `LUA_EXECUTABLE-NOTFOUND`. Ensure that in this case we are skipping the Lua tests requiring the interpreter.
3 participants
When Swig is installed but not any Lua interpreter, the cmake script in
lldb/cmake/modules/FindLuaAndSwig.cmakewill executefind_program(LUA_EXECUTABLE, ...)and this will set theLUA_EXECUTABLEvariable toLUA_EXECUTABLE-NOTFOUND.Ensure that in this case we are skipping the Lua tests requiring the interpreter.