Skip to content

Conversation

@InakiVA
Copy link
Contributor

@InakiVA InakiVA commented Oct 23, 2025

So it's treated as a comment and doesn't need to be manually removed from the output when used as IR.

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@aeubanks
Copy link
Contributor

patch looks good, the title/description should be clearer, like

Begin -print-on-crash output with semicolon

So it's treated as a comment and doesn't need to be manually removed from the output when used as IR.

no need to mention that you updated a test, that's expected

@aeubanks aeubanks self-requested a review October 23, 2025 22:01
@InakiVA InakiVA changed the title Added ; for commenting Begin -print-on-crash output with semicolon So it's treated as a comment and doesn't need to be manually removed from the output when used as IR. Oct 23, 2025
@InakiVA InakiVA changed the title Begin -print-on-crash output with semicolon So it's treated as a comment and doesn't need to be manually removed from the output when used as IR. Begin -print-on-crash output with semicolon Oct 23, 2025
@aeubanks aeubanks enabled auto-merge (squash) October 23, 2025 22:19
@aeubanks aeubanks merged commit a065505 into llvm:main Oct 27, 2025
9 of 10 checks passed
@github-actions
Copy link

@InakiVA Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Lukacma pushed a commit to Lukacma/llvm-project that referenced this pull request Oct 29, 2025
So it's treated as a comment and doesn't need to be manually removed
from the output when used as IR.
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
So it's treated as a comment and doesn't need to be manually removed
from the output when used as IR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants