[lldb] Fix TestVTableValue.py test_overwrite_vtable test #164910
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some machines have read-only vtables but this test expects to overwrite them Use -no_data_const to ensure the vtable is writable
|
@llvm/pr-subscribers-lldb Author: Daniel Sanders (dsandersllvm) ChangesSome machines have read-only vtables but this test expects to overwrite them Use -no_data_const to ensure the vtable is writable Full diff: https://github.com/llvm/llvm-project/pull/164910.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/vtable/Makefile b/lldb/test/API/functionalities/vtable/Makefile
index 99998b20bcb05..cbd7d472fb768 100644
--- a/lldb/test/API/functionalities/vtable/Makefile
+++ b/lldb/test/API/functionalities/vtable/Makefile
@@ -1,3 +1,9 @@
CXX_SOURCES := main.cpp
+ifeq "$(OS)" "Darwin"
+ # Make vtables writable for test_overwrite_vtable test
+ # The -no_data_const flag prevents vtables from being placed in __DATA_CONST
+ LD_EXTRAS := -Wl,-no_data_const
+endif
+
include Makefile.rules
|
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
Some machines have read-only vtables but this test expects to overwrite them. Use -no_data_const to ensure the vtable is writable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some machines have read-only vtables but this test expects to overwrite them Use -no_data_const to ensure the vtable is writable