Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

There are no other target specific passes in Passes.h and these really
belong inside x86.h to be consistent with other targets.

Created using spr 1.3.7
@llvmbot
Copy link
Member

llvmbot commented Oct 25, 2025

@llvm/pr-subscribers-backend-x86

Author: Aiden Grossman (boomanaiden154)

Changes

There are no other target specific passes in Passes.h and these really
belong inside x86.h to be consistent with other targets.


Full diff: https://github.com/llvm/llvm-project/pull/165075.diff

2 Files Affected:

  • (modified) llvm/include/llvm/CodeGen/Passes.h (-8)
  • (modified) llvm/lib/Target/X86/X86.h (+8)
diff --git a/llvm/include/llvm/CodeGen/Passes.h b/llvm/include/llvm/CodeGen/Passes.h
index 9fddd47b18965..a8525554b142e 100644
--- a/llvm/include/llvm/CodeGen/Passes.h
+++ b/llvm/include/llvm/CodeGen/Passes.h
@@ -610,14 +610,6 @@ LLVM_ABI ModulePass *createCheckDebugMachineModulePass();
 /// caller saved registers with stack slots.
 LLVM_ABI extern char &FixupStatepointCallerSavedID;
 
-/// The pass transforms load/store <256 x i32> to AMX load/store intrinsics
-/// or split the data to two <128 x i32>.
-LLVM_ABI FunctionPass *createX86LowerAMXTypePass();
-
-/// The pass transforms amx intrinsics to scalar operation if the function has
-/// optnone attribute or it is O0.
-LLVM_ABI FunctionPass *createX86LowerAMXIntrinsicsPass();
-
 /// When learning an eviction policy, extract score(reward) information,
 /// otherwise this does nothing
 LLVM_ABI FunctionPass *createRegAllocScoringPass();
diff --git a/llvm/lib/Target/X86/X86.h b/llvm/lib/Target/X86/X86.h
index 6261fadf10a7a..706ab2b62bc1b 100644
--- a/llvm/lib/Target/X86/X86.h
+++ b/llvm/lib/Target/X86/X86.h
@@ -160,6 +160,14 @@ FunctionPass *createX86PartialReductionPass();
 /// // Analyzes and emits pseudos to support Win x64 Unwind V2.
 FunctionPass *createX86WinEHUnwindV2Pass();
 
+/// The pass transforms load/store <256 x i32> to AMX load/store intrinsics
+/// or split the data to two <128 x i32>.
+FunctionPass *createX86LowerAMXTypePass();
+
+/// The pass transforms amx intrinsics to scalar operation if the function has
+/// optnone attribute or it is O0.
+FunctionPass *createX86LowerAMXIntrinsicsPass();
+
 InstructionSelector *createX86InstructionSelector(const X86TargetMachine &TM,
                                                   const X86Subtarget &,
                                                   const X86RegisterBankInfo &);

@boomanaiden154 boomanaiden154 merged commit 7be3cac into main Oct 25, 2025
12 checks passed
@boomanaiden154 boomanaiden154 deleted the users/boomanaiden154/x86-move-x86-specific-createpass-functions-to-x86h branch October 25, 2025 07:12
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Oct 25, 2025
There are no other target specific passes in Passes.h and these really
belong inside x86.h to be consistent with other targets.

Reviewers: arsenm, phoebewang, RKSimon, topperc

Reviewed By: arsenm

Pull Request: llvm/llvm-project#165075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants