-
Notifications
You must be signed in to change notification settings - Fork 15k
[XRay] Make Test Work with Internal Shell #165143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
boomanaiden154
merged 8 commits into
main
from
users/boomanaiden154/xray-make-test-work-with-internal-shell
Oct 30, 2025
Merged
[XRay] Make Test Work with Internal Shell #165143
boomanaiden154
merged 8 commits into
main
from
users/boomanaiden154/xray-make-test-work-with-internal-shell
Oct 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
|
@llvm/pr-subscribers-xray Author: Aiden Grossman (boomanaiden154) ChangesThere was one test that set an environment variable without using env Full diff: https://github.com/llvm/llvm-project/pull/165143.diff 1 Files Affected:
diff --git a/compiler-rt/test/xray/TestCases/Posix/fdr-single-thread.cpp b/compiler-rt/test/xray/TestCases/Posix/fdr-single-thread.cpp
index b8803aedc8851..36a4e65988f9a 100644
--- a/compiler-rt/test/xray/TestCases/Posix/fdr-single-thread.cpp
+++ b/compiler-rt/test/xray/TestCases/Posix/fdr-single-thread.cpp
@@ -1,11 +1,12 @@
// RUN: %clangxx_xray -g -std=c++11 %s -o %t
// RUN: rm -f fdr-logging-1thr-*
-// RUN: XRAY_OPTIONS=XRAY_OPTIONS="verbosity=1 patch_premain=true \
+// RUN: env XRAY_OPTIONS=XRAY_OPTIONS="verbosity=1 patch_premain=true \
// RUN: xray_fdr_log=true \
// RUN: xray_fdr_log_func_duration_threshold_us=0 \
// RUN: xray_logfile_base=fdr-logging-1thr-" %run %t 2>&1
+// RUN: ls fdr-logging-1thr-* | head -n1 | tr -d '\n' > %t.xray_input
// RUN: %llvm_xray convert --output-format=yaml --symbolize --instr_map=%t \
-// RUN: "`ls fdr-logging-1thr-* | head -n1`" | FileCheck %s
+// RUN: "%{readfile:%t.xray_input}" | FileCheck %s
// RUN: rm fdr-logging-1thr-*
// UNSUPPORTED: target=arm{{.*}}
|
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 26, 2025
There was one test that set an environment variable without using env and also used a subshell. These are features the internal shell does not support. Rewrite the test to use readfile/env. Pull Request: llvm#165143
fmayer
approved these changes
Oct 27, 2025
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There was one test that set an environment variable without using env and also used a subshell. These are features the internal shell does not support. Rewrite the test to use readfile/env. Pull Request: llvm#165143
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There was one test that set an environment variable without using env and also used a subshell. These are features the internal shell does not support. Rewrite the test to use readfile/env. Pull Request: llvm#165143
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 30, 2025
There was one test that set an environment variable without using env and also used a subshell. These are features the internal shell does not support. Rewrite the test to use readfile/env. Pull Request: llvm#165143
Created using spr 1.3.7 [skip ci]
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 30, 2025
There was one test that set an environment variable without using env and also used a subshell. These are features the internal shell does not support. Rewrite the test to use readfile/env. Reviewers: fmayer, MaskRay Reviewed By: fmayer Pull Request: llvm/llvm-project#165143
luciechoi
pushed a commit
to luciechoi/llvm-project
that referenced
this pull request
Nov 1, 2025
There was one test that set an environment variable without using env and also used a subshell. These are features the internal shell does not support. Rewrite the test to use readfile/env. Reviewers: fmayer, MaskRay Reviewed By: fmayer Pull Request: llvm#165143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one test that set an environment variable without using env
and also used a subshell. These are features the internal shell does not
support. Rewrite the test to use readfile/env.