[CodeGen] Use DenseMap::try_emplace (NFC) #165165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With try_emplace, we can pass the key and the arguments for the value's constructor, which is a lot shorter than: Map.insert(std::make_pair(Key, ValueType(Arg1, Arg2)))
arsenm
approved these changes
Oct 26, 2025
varun-r-mallya
pushed a commit
to varun-r-mallya/llvm-project
that referenced
this pull request
Oct 27, 2025
With try_emplace, we can pass the key and the arguments for the value's constructor, which is a lot shorter than: Map.insert(std::make_pair(Key, ValueType(Arg1, Arg2)))
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
With try_emplace, we can pass the key and the arguments for the value's constructor, which is a lot shorter than: Map.insert(std::make_pair(Key, ValueType(Arg1, Arg2)))
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
With try_emplace, we can pass the key and the arguments for the value's constructor, which is a lot shorter than: Map.insert(std::make_pair(Key, ValueType(Arg1, Arg2)))
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
With try_emplace, we can pass the key and the arguments for the value's constructor, which is a lot shorter than: Map.insert(std::make_pair(Key, ValueType(Arg1, Arg2)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With try_emplace, we can pass the key and the arguments for the
value's constructor, which is a lot shorter than:
Map.insert(std::make_pair(Key, ValueType(Arg1, Arg2)))