Skip to content

[UBSan] Add check that detects division by zero for fixed-point types #165181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[UBSan] Add check that detects division by zero for fixed-point types #165181

wants to merge 3 commits into from

Conversation

@localspook
Copy link
Contributor

No description provided.

vitalybuka
vitalybuka reviewed Oct 27, 2025
View reviewed changes
clang/include/clang/Basic/Sanitizers.def
SANITIZER_GROUP("undefined", Undefined,
Alignment | Bool | Builtin | ArrayBounds | Enum |
FloatCastOverflow |
FixedPoint | FloatCastOverflow |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no standard fixed point type, so it should not be a part of "undefined"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the N1169 extensions. See #43241 for example. (I'll write a more detailed PR message, but I wanted to make sure the tests pass first.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitalybuka vitalybuka vitalybuka left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@localspook @vitalybuka