Skip to content

ARM: Avoid doing strncmp on libcall name #165203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

ARM: Avoid doing strncmp on libcall name #165203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86fdd93
ARM: Avoid doing strncmp on libcall name
arsenm Oct 27, 2025
446dd8e
inline isAEABIFunctionImpl
arsenm Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions llvm/lib/Target/ARM/ARMSelectionDAGInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ SDValue ARMSelectionDAGInfo::EmitSpecializedLibcall(

// Only use a specialized AEABI function if the default version of this
// Libcall is an AEABI function.
if (std::strncmp(TLI->getLibcallName(LC), "__aeabi", 7) != 0)
return SDValue();

//
// Translate RTLIB::Libcall to AEABILibcall. We only do this in order to be
// able to translate memset to memclr and use the value to index the function
// name array.
Expand All @@ -61,12 +59,21 @@ SDValue ARMSelectionDAGInfo::EmitSpecializedLibcall(
} AEABILibcall;
switch (LC) {
case RTLIB::MEMCPY:
if (TLI->getLibcallImpl(LC) != RTLIB::impl___aeabi_memcpy)
return SDValue();

AEABILibcall = AEABI_MEMCPY;
break;
case RTLIB::MEMMOVE:
if (TLI->getLibcallImpl(LC) != RTLIB::impl___aeabi_memmove)
return SDValue();

AEABILibcall = AEABI_MEMMOVE;
break;
case RTLIB::MEMSET:
if (TLI->getLibcallImpl(LC) != RTLIB::impl___aeabi_memset)
return SDValue();

AEABILibcall = AEABI_MEMSET;
if (isNullConstant(Src))
AEABILibcall = AEABI_MEMCLR;
Expand Down