[nsan] More unit tests for float128.
#165248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that llvm-libc has `nextafterf128`.
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Clement Courbet (legrosbuffle) ChangesNow that llvm-libc has Full diff: https://github.com/llvm/llvm-project/pull/165248.diff 1 Files Affected:
diff --git a/compiler-rt/lib/nsan/tests/NSanUnitTest.cpp b/compiler-rt/lib/nsan/tests/NSanUnitTest.cpp
index d121292c36682..73b59671fe07a 100644
--- a/compiler-rt/lib/nsan/tests/NSanUnitTest.cpp
+++ b/compiler-rt/lib/nsan/tests/NSanUnitTest.cpp
@@ -43,8 +43,8 @@ template <typename FT, auto next> void TestFT() {
ASSERT_EQ(GetULPDiff<FT>(-X, -Y), 3);
// Values with larger differences.
- static constexpr const __sanitizer::u64 MantissaSize =
- __sanitizer::u64{1} << FTInfo<FT>::kMantissaBits;
+ static constexpr const __uint128_t MantissaSize =
+ __uint128_t{1} << FTInfo<FT>::kMantissaBits;
ASSERT_EQ(GetULPDiff<FT>(1.0, next(2.0, 1.0)), MantissaSize - 1);
ASSERT_EQ(GetULPDiff<FT>(1.0, 2.0), MantissaSize);
ASSERT_EQ(GetULPDiff<FT>(1.0, next(2.0, 3.0)), MantissaSize + 1);
@@ -57,11 +57,6 @@ TEST(NSanTest, Double) {
TestFT<double, static_cast<double (*)(double, double)>(nextafter)>();
}
-TEST(NSanTest, Float128) {
- // Very basic tests. FIXME: improve when we have nextafter<__float128>.
- ASSERT_EQ(GetULPDiff<__float128>(0.0, 0.0), 0);
- ASSERT_EQ(GetULPDiff<__float128>(-0.0, 0.0), 0);
- ASSERT_NE(GetULPDiff<__float128>(-0.01, 0.01), kMaxULPDiff);
-}
+TEST(NSanTest, Float128) { TestFT<__float128, nextafterf128>(); }
} // end namespace __nsan
|
alexander-shaposhnikov
approved these changes
Oct 28, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/13515 Here is the relevant piece of the build log for the reference |
|
I'm seeing Can you revert or fix-forward? |
legrosbuffle
added a commit
that referenced
this pull request
Oct 28, 2025
legrosbuffle
added a commit
that referenced
this pull request
Oct 28, 2025
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
Now that llvm-libc has `nextafterf128`.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
Now that llvm-libc has `nextafterf128`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that llvm-libc has
nextafterf128.