[compiler-rt][x86] Don't use assert.h when building without a libc #165384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
compnerd
reviewed
Oct 29, 2025
|
|
||
| #if defined(__GNUC__) || defined(__clang__) || defined(_MSC_VER) | ||
|
|
||
| #if defined(__linux__) && __STDC_HOSTED__ |
There was a problem hiding this comment.
I saw nearby files using __linux__ as the checking macro for assert.h, so I added it
but just __STDC_HOSTED__ should be fine as well
should I remove __linux__?
There was a problem hiding this comment.
Yes, please remove __linux__. Using __STDC_HOSTED__ is reasonable - that indicates we are in a hosted environment (we have libc).
| } else | ||
| __cpu_model.__cpu_vendor = VENDOR_OTHER; | ||
|
|
||
| #if defined(__linux__) && __STDC_HOSTED__ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #164932