Skip to content

[flang][Driver] Accept (and ignore) some gfortran-specific options #165579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+133 −4
Open

[flang][Driver] Accept (and ignore) some gfortran-specific options #165579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95baa7d
[flang][Driver] Accept (and ignore) some gfortran-specific options
Oct 29, 2025
c6cfb19
Minor formatting and renaming
tarunprabhu Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clang/include/clang/Driver/Options.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,8 @@ def mno_mpx : Flag<["-"], "mno-mpx">, Group<clang_ignored_legacy_options_Group>;

// Group that ignores all gcc optimizations that won't be implemented
def clang_ignored_gcc_optimization_f_Group : OptionGroup<
"<clang_ignored_gcc_optimization_f_Group>">, Group<f_Group>, Flags<[Ignored]>;
"<clang_ignored_gcc_optimization_f_Group>">,
Group<f_Group>, Flags<[Ignored]>, Visibility<[ClangOption, FlangOption]>;

class DiagnosticOpts<string base>
: KeyPathAndMacro<"DiagnosticOpts->", base, "DIAG_"> {}
Expand Down
8 changes: 8 additions & 0 deletions clang/lib/Driver/ToolChains/Flang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,6 +952,14 @@ void Flang::ConstructJob(Compilation &C, const JobAction &JA,
if (const Arg *A = Args.getLastArg(Opt))
D.Diag(diag::warn_drv_invalid_argument_for_flang) << A->getSpelling();

// Warn about options that are ignored by flang. These are options that are
// accepted by gfortran, but have no equivalent in flang.
for (const Arg *A :
Args.filtered(options::OPT_clang_ignored_gcc_optimization_f_Group)) {
D.Diag(diag::warn_ignored_gcc_optimization) << A->getAsString(Args);
A->claim();
}

const InputInfo &Input = Inputs[0];
types::ID InputType = Input.getType();

Expand Down
126 changes: 123 additions & 3 deletions flang/test/Driver/flang-f-opts.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,21 @@
! RUN: %flang -### -S -fprofile-use=%S %s 2>&1 | FileCheck -check-prefix=CHECK-PROFILE-USE-DIR %s
! CHECK-PROFILE-USE-DIR: "-fprofile-use={{.*}}"

! ------------------------------------------------------------------------------
! RUN: %flang -### -fbuiltin %s 2>&1 \
! RUN: | FileCheck %s -check-prefix=WARN-BUILTIN
! WARN-BUILTIN: warning: '-fbuiltin' is not valid for Fortran

!
! RUN: %flang -### -fno-builtin %s 2>&1 \
! RUN: | FileCheck %s -check-prefix=WARN-NO-BUILTIN
! WARN-NO-BUILTIN: warning: '-fno-builtin' is not valid for Fortran

!
! RUN: %flang -### -fbuiltin -fno-builtin %s 2>&1 \
! RUN: | FileCheck %s -check-prefix=WARN-BUILTIN-MULTIPLE
! WARN-BUILTIN-MULTIPLE: warning: '-fbuiltin' is not valid for Fortran
! WARN-BUILTIN-MULTIPLE: warning: '-fno-builtin' is not valid for Fortran

!
!-------------------------------------------------------------------------------
! When emitting an error with a suggestion, ensure that the diagnostic message
! uses '-Xflang' instead of '-Xclang'. This is typically emitted when an option
! that is available for `flang -fc1` is passed to `flang`. We use -complex-range
Expand All @@ -43,3 +45,121 @@
! RUN: | FileCheck %s -check-prefix UNKNOWN-NO-SUGGEST
!
! UNKNOWN-NO-SUGGEST: error: unknown argument: '-not-an-option'{{$}}
!
!-------------------------------------------------------------------------------
! The options in the command below are gfortran-specific optimization flags that
! are accepted by flang's driver but ignored. Check that the correct warning
! message is displayed when these are used.
!
! RUN: %flang -### %s \
! RUN: -finline-limit=1000 \
! RUN: -finline-limit \
! RUN: -fexpensive-optimizations \
! RUN: -fno-expensive-optimizations \
! RUN: -fno-defer-pop \
! RUN: -fkeep-inline-functions \
! RUN: -fno-keep-inline-functions \
! RUN: -freorder-blocks \
! RUN: -ffloat-store \
! RUN: -fgcse \
! RUN: -fivopts \
! RUN: -fprefetch-loop-arrays \
! RUN: -fprofile-correction \
! RUN: -fprofile-values \
! RUN: -fschedule-insns \
! RUN: -fsignaling-nans \
! RUN: -fstrength-reduce \
! RUN: -ftracer \
! RUN: -funroll-all-loops \
! RUN: -funswitch-loops \
! RUN: -falign-labels \
! RUN: -falign-labels=100 \
! RUN: -falign-jumps \
! RUN: -falign-jumps=100 \
! RUN: -fbranch-count-reg \
! RUN: -fcaller-saves \
! RUN: -fno-default-inline \
! RUN: -fgcse-after-reload \
! RUN: -fgcse-las \
! RUN: -fgcse-sm \
! RUN: -fipa-cp \
! RUN: -finline-functions-called-once \
! RUN: -fmodulo-sched \
! RUN: -fmodulo-sched-allow-regmoves \
! RUN: -fpeel-loops \
! RUN: -frename-registers \
! RUN: -fschedule-insns2 \
! RUN: -fsingle-precision-constant \
! RUN: -funsafe-loop-optimizations \
! RUN: -fuse-linker-plugin \
! RUN: -fvect-cost-model \
! RUN: -fvariable-expansion-in-unroller \
! RUN: -fweb \
! RUN: -fwhole-program \
! RUN: -fcaller-saves \
! RUN: -freorder-blocks \
! RUN: -ffat-lto-objects \
! RUN: -fmerge-constants \
! RUN: -finline-small-functions \
! RUN: -ftree-dce \
! RUN: -ftree-ter \
! RUN: -ftree-vrp \
! RUN: -fno-devirtualize \
! RUN: -fno-devirtualize-speculatively 2>&1 \
! RUN: | FileCheck --check-prefix=WARN-UNSUPPORTED %s
!
! WARN-UNSUPPORTED-DAG: optimization flag '-finline-limit=1000' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-finline-limit' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fexpensive-optimizations' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fno-expensive-optimizations' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fno-defer-pop' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fkeep-inline-functions' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fno-keep-inline-functions' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-freorder-blocks' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-ffloat-store' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fgcse' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fivopts' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fprefetch-loop-arrays' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fprofile-correction' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fprofile-values' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fschedule-insns' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fsignaling-nans' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fstrength-reduce' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-ftracer' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-funroll-all-loops' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-funswitch-loops' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-falign-labels' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-falign-labels=100' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-falign-jumps' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-falign-jumps=100' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fbranch-count-reg' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fcaller-saves' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fno-default-inline' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fgcse-after-reload' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fgcse-las' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fgcse-sm' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fipa-cp' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-finline-functions-called-once' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fmodulo-sched' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fmodulo-sched-allow-regmoves' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fpeel-loops' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-frename-registers' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fschedule-insns2' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fsingle-precision-constant' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-funsafe-loop-optimizations' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fuse-linker-plugin' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fvect-cost-model' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fvariable-expansion-in-unroller' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fweb' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fwhole-program' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fcaller-saves' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-freorder-blocks' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fmerge-constants' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-finline-small-functions' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-ftree-dce' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-ftree-ter' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-ftree-vrp' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fno-devirtualize' is not supported
! WARN-UNSUPPORTED-DAG: optimization flag '-fno-devirtualize-speculatively' is not supported
!
! ------------------------------------------------------------------------------