Skip to content

[LifetimeSafety] Fix Python path for Windows compatibility #166291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

[LifetimeSafety] Fix Python path for Windows compatibility #166291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions clang/test/Analysis/LifetimeSafety/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,21 @@ set(LIFETIME_BENCHMARK_REQUIREMENTS
set(LIFETIME_BENCHMARK_OUTPUT_DIR
"${CMAKE_CURRENT_BINARY_DIR}/benchmark_results")

if(WIN32)
set(LIFETIME_BENCHMARK_VENV_PYTHON_EXECUTABLE
"${LIFETIME_BENCHMARK_VENV_DIR}/Scripts/python")
else()
set(LIFETIME_BENCHMARK_VENV_PYTHON_EXECUTABLE
"${LIFETIME_BENCHMARK_VENV_DIR}/bin/python")
endif()

if(EXISTS ${LIFETIME_BENCHMARK_SCRIPT} AND EXISTS ${LIFETIME_BENCHMARK_REQUIREMENTS})

# Set up the virtual environment and install packages
add_custom_command(
OUTPUT ${LIFETIME_BENCHMARK_VENV_DIR}/pyvenv.cfg
COMMAND ${Python3_EXECUTABLE} -m venv ${LIFETIME_BENCHMARK_VENV_DIR}
COMMAND ${LIFETIME_BENCHMARK_VENV_DIR}/bin/python -m pip install -r ${LIFETIME_BENCHMARK_REQUIREMENTS}
COMMAND ${LIFETIME_BENCHMARK_VENV_PYTHON_EXECUTABLE} -m pip install -r ${LIFETIME_BENCHMARK_REQUIREMENTS}
DEPENDS ${LIFETIME_BENCHMARK_REQUIREMENTS}
COMMENT "Creating Python virtual environment and installing dependencies for benchmark..."
)
Expand All @@ -32,7 +39,7 @@ if(EXISTS ${LIFETIME_BENCHMARK_SCRIPT} AND EXISTS ${LIFETIME_BENCHMARK_REQUIREME

# Main benchmark target
add_custom_target(benchmark_lifetime_safety_analysis
COMMAND ${LIFETIME_BENCHMARK_VENV_DIR}/bin/python ${LIFETIME_BENCHMARK_SCRIPT}
COMMAND ${LIFETIME_BENCHMARK_VENV_PYTHON_EXECUTABLE} ${LIFETIME_BENCHMARK_SCRIPT}
--clang-binary ${LLVM_BINARY_DIR}/bin/clang
--output-dir ${LIFETIME_BENCHMARK_OUTPUT_DIR}

Expand Down