[z/OS] Improve compiler options on z/OS #166415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_XPLATFORM_SOURCE` needs to be defined to improve source code compatibility (e.g. for `O_CLOEXEC`). The define `_UNIX03_THREADS` can be removed, because it is automatically set by `_XOPEN_SOURCE=600`. See the documentation of feature test macros: https://www.ibm.com/docs/en/zos/3.1.0?topic=files-feature-test-macros Tested on z/OS 3.1 with the Open XL C/C++ 2.2 compiler.
abhina-sree
approved these changes
Nov 4, 2025
llvm/CMakeLists.txt
Outdated
| # Build with _XOPEN_SOURCE on z/OS. | ||
| if (CMAKE_SYSTEM_NAME MATCHES "OS390") | ||
| add_compile_definitions(_XOPEN_SOURCE=600) | ||
| add_compile_definitions(_XPLATFORM_SOURCE) |
Contributor
There was a problem hiding this comment.
nit: can we add a comment that we need this for O_CLOEXEC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_XPLATFORM_SOURCEneeds to be defined to improve source code compatibility (e.g. forO_CLOEXEC). The define_UNIX03_THREADScan be removed, because it is automatically set by_XOPEN_SOURCE=600.See the documentation of feature test macros: https://www.ibm.com/docs/en/zos/3.1.0?topic=files-feature-test-macros
Tested on z/OS 3.1 with the Open XL C/C++ 2.2 compiler.