Skip to content

[PGO][Offload] Fix missing names bug in GPU PGO #166444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

[PGO][Offload] Fix missing names bug in GPU PGO #166444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30eaf06
[PGO][Offload] Fix missing names bug in GPU PGO
EthanLuisMcDonough Nov 4, 2025
b6642c2
Merge branch 'main' into gpupgo-names-fix-pr
jhuber6 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1944,6 +1944,10 @@ void InstrLowerer::emitNameData() {
NamesVar = new GlobalVariable(M, NamesVal->getType(), true,
GlobalValue::PrivateLinkage, NamesVal,
getInstrProfNamesVarName());
if (isGPUProfTarget(M)) {
NamesVar->setLinkage(GlobalValue::ExternalLinkage);
NamesVar->setVisibility(GlobalValue::ProtectedVisibility);
}

NamesSize = CompressedNameStr.size();
setGlobalVariableLargeSection(TT, *NamesVar);
Expand Down
1 change: 0 additions & 1 deletion offload/test/offloading/gpupgo/pgo_atomic_teams.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

// REQUIRES: amdgpu
// REQUIRES: pgo
// XFAIL: amdgpu

int test1(int a) { return a / 2; }
int test2(int a) { return a * 2; }
Expand Down
1 change: 0 additions & 1 deletion offload/test/offloading/gpupgo/pgo_atomic_threads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

// REQUIRES: amdgpu
// REQUIRES: pgo
// XFAIL: amdgpu

int test1(int a) { return a / 2; }

Expand Down
1 change: 0 additions & 1 deletion offload/test/offloading/gpupgo/pgo_device_and_host.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@

// REQUIRES: amdgpu
// REQUIRES: pgo
// XFAIL: amdgpu

int main() {
int host_var = 0;
Expand Down
1 change: 0 additions & 1 deletion offload/test/offloading/gpupgo/pgo_device_only.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

// REQUIRES: amdgpu
// REQUIRES: pgo
// XFAIL: amdgpu

int test1(int a) { return a / 2; }
int test2(int a) { return a * 2; }
Expand Down