Skip to content

[MLIR] Fix generate-test-checks.py to not remove every blank lines #166493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

[MLIR] Fix generate-test-checks.py to not remove every blank lines #166493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions mlir/utils/generate-test-checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,11 @@ def process_line(line_chunks, variable_namer, use_ssa_name=False, strict_name_re


# Process the source file lines. The source file doesn't have to be .mlir.
def process_source_lines(source_lines, note, args):
def process_source_lines(source_lines, args):
source_split_re = re.compile(args.source_delim_regex)

source_segments = [[]]
for line in source_lines:
# Remove previous note.
if line in note:
continue
# Remove previous CHECK lines.
if line.find(args.check_prefix) != -1:
continue
Expand Down Expand Up @@ -359,9 +356,10 @@ def main():

source_segments = None
if args.source:
source_segments = process_source_lines(
[l.rstrip() for l in open(args.source, "r")], autogenerated_note, args
)
with open(args.source, "r") as f:
raw_source = f.read().replace(autogenerated_note, "")
raw_source_lines = [l.rstrip() for l in raw_source.splitlines()]
source_segments = process_source_lines(raw_source_lines, args)

if args.inplace:
assert args.output is None
Expand Down