Skip to content

Conversation

@MixedMatched
Copy link
Contributor

GitHub's Update Branch button is a helpful tool for quickly updating a PR before merging, but it might also be important to point out that it creates a merge commit without additional prompting, which may or may not be desired behavior for a given LLVM contributor.

Opened on the suggestion of @lamb-j

you must use the pull request title and description as the commit message.
You can do this manually with an interactive git rebase or with GitHub's
built-in tool. See the section about landing your fix below.
If you create fix up or merge commits, you must squash and merge before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still possible to do a non-squashed merge? Maybe via the CLI?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still allow direct pushes to main, so maybe the CLI allows for pushing a non-squashed merge?

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improved docs! I think the changes are an improvement, so LGTM! But please give others a few days to weigh in before landing the changes.

CC @tstellar @tru in case they think any of the docs should be updated for the release branch vs main branch differences

you must use the pull request title and description as the commit message.
You can do this manually with an interactive git rebase or with GitHub's
built-in tool. See the section about landing your fix below.
If you create fix up or merge commits, you must squash and merge before
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still allow direct pushes to main, so maybe the CLI allows for pushing a non-squashed merge?

@lamb-j lamb-j merged commit 66e97aa into llvm:main Nov 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants